OCram85
/
PSCredentialStore
1
0
Fork 1
Code Issues 1 Pull Requests Releases 26 Activity
Labels Milestones

adds pinguinfuss contributed fix #73

Merged
OCram85 merged 1 commits from pinguinfussFix into master 5 months ago
Conversation 2 Commits 1 Files Changed 2
OCram85 commented 5 months ago
Owner

📖 Summary

  • redo PR from @pinguinfuss
    • fix error message
    • fix string quotation

📑 Test Plan

💡 Select your test plan for the code changes.

  • Tested via Drone.io pipeline
  • Custom test
  • No test plan
Details / Justification

📚 Additional Notes

  • just redo #72.
    • there was an issue caused by git config core.autocrl displaying / diffin the wrong line ending sequence
#### :book: Summary - redo PR from @pinguinfuss - fix error message - fix string quotation #### :bookmark_tabs: Test Plan > :bulb: Select your test plan for the code changes. - [x] Tested via Drone.io pipeline - [ ] Custom test - [ ] No test plan ##### Details / Justification <!-- Add your test details or justification for missing tests here. --> #### :books: Additional Notes - just redo #72. - there was an issue caused by git config `core.autocrl` displaying / diffin the wrong line ending sequence
OCram85 added 1 commit 5 months ago
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
d2c4d2a1e1 add pinguinfuss contributed fix
OCram85 added the
bug
meta
 labels 5 months ago
OCram85 commented 5 months ago
Poster
Owner

Bumping @pinguinfuss into this: Are you happy with this ❔

Bumping @pinguinfuss into this: Are you happy with this ❔
ci-bot commented 5 months ago
Collaborator

Drone.io PR Build No. #108: success

/drone/src/build/FileLinter-Results.log

✔️ No FileLinter violations in 31 files found.

/drone/src/build/Pester-Results.log

Result Test Duration
⚠️ Test-CredentialStore.Basic logic tests.Read a broken CredentialStore 0ms

🧪 49 Total Tests (✔️ 48 Passed ▫️🔱 1 Skipped / NotRun ▫️ ⚠️ Unknown ▫️ ❗ 0 Failed)
📑 Covered 38.77% / 75%. (🔖 779 analyzed Commands 📄 in 25 Files)

/drone/src/build/ScriptAnalyzer-Results.log

✔️ No violations found.

end.

> Drone.io PR Build No. [#108](https://drone.ocram85.com/OCram85/PSCredentialStore/108): ``success`` #### ``/drone/src/build/FileLinter-Results.log`` :heavy_check_mark: No FileLinter violations in 31 files found. #### ``/drone/src/build/Pester-Results.log`` | Result | Test | Duration | | :----: | :--- | -------: | | :warning: | `Test-CredentialStore.Basic logic tests.Read a broken CredentialStore` | *0ms* | :test_tube: **49** Total Tests (:heavy_check_mark: ``48 Passed`` :white_small_square::trident: ``1 Skipped / NotRun`` :white_small_square: :warning: ``Unknown`` :white_small_square: :heavy_exclamation_mark: ``0 Failed``) :bookmark_tabs: Covered **38.77%** / 75%. (:bookmark: ``779 analyzed Commands`` :page_facing_up: ``in 25 Files``) #### ``/drone/src/build/ScriptAnalyzer-Results.log`` :heavy_check_mark: No violations found. end.
OCram85 merged commit 3d4f53ddc7 into master 5 months ago
OCram85 deleted branch pinguinfussFix 5 months ago
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
The pull request has been merged as 3d4f53ddc7.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something is not working docs
Changes related to the docs output duplicate
This issue or pull request already exists enhancement
New feature feature
Adds a new feature help wanted
Need some help invalid
Something is wrong meta
Changes related to general project files question
More information is needed wontfix
This won't be fixed
No Label bug docs duplicate enhancement feature help wanted invalid meta question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OCram85/PSCredentialStore#73
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'pinguinfussFix'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes