New-CredentialStoreItem-Warn-If-CredentialStore-Doesnt-Exist #72

Closed

pinguinfuss wants to merge 6 commits from pinguinfuss:New-CredentialStoreItem-Warn-If-CredentialStore-Doesnt-Exist into master

pull from: pinguinfuss:New-CredentialStoreItem-Warn-If-CredentialStore-Doesnt-Exist

merge into: OCram85:master

OCram85:master

Conversation 2 Commits 6 Files Changed 2 +169 -169

pinguinfuss commented 2022-09-20 08:41:49 +02:00

Contributor

Copy Link

📖 Summary

Fix errror message of New-CredentialStoreItem when no CredentialStore exists.

📑 Test Plan

Test-CredentialStore
False
New-CredentialStoreItem -RemoteHost hans.wurst.one
New-CredentialStoreItem : The given credential store (C:\Users\pinguinfuss\AppData\Roaming\CredentialStore.json) does not exist!
In Zeile:1 Zeichen:1

• New-CredentialStoreItem -RemoteHost hans.wurst.one

•   + CategoryInfo          : NotSpecified: (:) [Write-Error], FileNotFoundException
    + FullyQualifiedErrorId : System.IO.FileNotFoundException,New-CredentialStoreItem
  
  

• Tested via Drone.io pipeline
• Custom test
• No test plan

#### :book: Summary Fix errror message of New-CredentialStoreItem when no CredentialStore exists. #### :bookmark_tabs: Test Plan Test-CredentialStore False New-CredentialStoreItem -RemoteHost hans.wurst.one New-CredentialStoreItem : The given credential store (C:\Users\pinguinfuss\AppData\Roaming\CredentialStore.json) does not exist! In Zeile:1 Zeichen:1 + New-CredentialStoreItem -RemoteHost hans.wurst.one + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : NotSpecified: (:) [Write-Error], FileNotFoundException + FullyQualifiedErrorId : System.IO.FileNotFoundException,New-CredentialStoreItem - [x] Tested via Drone.io pipeline - [ ] Custom test - [ ] No test plan

pinguinfuss added 3 commits 2022-09-20 08:41:49 +02:00

Fix the error message to be a bit more specific, as to why the CredentialStoreItem could not be added. 055db88324

Fix string quoting. This is not using string expansion, so it's not needed to use double-quotes. 0c87e6b9c0

Revert back to LF a962a5f703

pinguinfuss added 1 commit 2022-09-20 08:44:54 +02:00

Convert back to CRLF 40c77e3434

pinguinfuss added 1 commit 2022-09-20 08:48:20 +02:00

Fix test pipeline errors 948b42548e

OCram85 added 1 commit 2022-09-20 11:59:15 +02:00

Merge branch 'master' into New-CredentialStoreItem-Warn-If-CredentialStore-Doesnt-Exist a5e2ec8cce

ci-bot commented 2022-09-20 12:00:44 +02:00

Collaborator

Copy Link

Drone.io PR Build No. #106: failed

/drone/src/build/FileLinter-Results.log

Result	File	Failed
❗	/drone/src/src/Item/New-CredentialStoreItem.ps1	EOL, EOF

/drone/src/build/Pester-Results.log

Result	Test	Duration
⚠️	Test-CredentialStore.Basic logic tests.Read a broken CredentialStore	0ms

🧪 49 Total Tests (✔️ 48 Passed ▫️🔱 1 Skipped / NotRun ▫️ ⚠️ Unknown ▫️ ❗ 0 Failed)
📑 Covered 38.77% / 75%. (🔖 779 analyzed Commands 📄 in 25 Files)

/drone/src/build/ScriptAnalyzer-Results.log

✔️ No violations found.

end.

> Drone.io PR Build No. [#106](https://drone.ocram85.com/OCram85/PSCredentialStore/106): ``failed`` #### ``/drone/src/build/FileLinter-Results.log`` | Result | File | Failed | | :----: | :--- | -----: | | :heavy_exclamation_mark: | `/drone/src/src/Item/New-CredentialStoreItem.ps1` | `EOL, EOF` | #### ``/drone/src/build/Pester-Results.log`` | Result | Test | Duration | | :----: | :--- | -------: | | :warning: | `Test-CredentialStore.Basic logic tests.Read a broken CredentialStore` | *0ms* | :test_tube: **49** Total Tests (:heavy_check_mark: ``48 Passed`` :white_small_square::trident: ``1 Skipped / NotRun`` :white_small_square: :warning: ``Unknown`` :white_small_square: :heavy_exclamation_mark: ``0 Failed``) :bookmark_tabs: Covered **38.77%** / 75%. (:bookmark: ``779 analyzed Commands`` :page_facing_up: ``in 25 Files``) #### ``/drone/src/build/ScriptAnalyzer-Results.log`` :heavy_check_mark: No violations found. end.

OCram85 referenced this pull request 2022-09-20 12:18:58 +02:00

adds pinguinfuss contributed fix #73

OCram85 referenced this issue from a commit 2022-09-20 15:01:06 +02:00

adds pinguinfuss contributed fix (#73)

OCram85 commented 2022-09-21 07:09:45 +02:00

Owner

Copy Link

implemented with #73

implemented with #73

OCram85 closed this pull request 2022-09-21 07:09:45 +02:00

OCram85 deleted branch New-CredentialStoreItem-Warn-If-CredentialStore-Doesnt-Exist 2022-09-21 07:09:53 +02:00

Some checks failed

Hide all checks

continuous-integration/drone/pr Build is failing

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

docs

Changes related to the docs output

duplicate

This issue or pull request already exists

enhancement

New feature

feature

Adds a new feature

help wanted

Need some help

invalid

Something is wrong

meta

Changes related to general project files

question

More information is needed

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

ci-bot OCram85

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OCram85/PSCredentialStore#72

No description provided.