Archived
1
0
Commit Graph

1411 Commits

Author SHA1 Message Date
f4d7f00033 plugin.ts: Fixes for @wbobeirne 2020-11-06 10:12:46 -05:00
ef971009d9 plugin.test.ts: Make it clear iconPath is a path 2020-11-06 10:12:46 -05:00
30d2962e21 src/node/plugin.ts: Warn on duplicate plugin and only load first 2020-11-06 10:12:46 -05:00
82e8a00a0d Fix CI 2020-11-06 10:12:46 -05:00
bea185b8b2 plugin: Add basic loading test
Will work on testing overlay next.
2020-11-06 10:12:46 -05:00
e08a55d44a src/node/plugin.ts: Implement new plugin API 2020-11-06 10:12:45 -05:00
481df70622 ci/dev/test.sh: Pass through args 2020-11-06 10:11:57 -05:00
aa2cfa2c17 typings/plugin.d.ts: Create 2020-11-06 10:11:57 -05:00
959497067c Document HttpError
Also type the status.
2020-11-05 17:07:58 -06:00
f7076247f9 Move domain proxy to routes
This matches better with the other routes.

Also add a missing authentication check to the path proxy web socket.
2020-11-05 17:07:32 -06:00
f6c4434191 Tweak proxy fallthrough behavior
It will now redirect all HTML requests. Also it avoids req.accepts since
that's always truthy.
2020-11-05 16:49:30 -06:00
cb991a9143 Handle errors for JSON requests
Previously it would have just given them the error HTML.
2020-11-05 15:19:56 -06:00
3f1750cf83 Fix destroying response in update again
I added another reject that doesn't destroy the response.
2020-11-05 15:08:10 -06:00
7b2752a62c Move websocket routes into a separate app
This is mostly so we don't have to do any wacky patching but it also
makes it so we don't have to keep checking if the request is a web
socket request every time we add middleware.
2020-11-05 15:08:09 -06:00
9e09c1f92b Upgrade to Express 5
Now async routes are handled!
2020-11-05 15:08:08 -06:00
8252c372af Provide a way to tell when event handlers are finished
This lets us actually wait for disposal before a graceful exit.
2020-11-05 15:08:07 -06:00
396af23842 Kill VS Code when process exits
This is to ensure it doesn't hang around.
2020-11-04 17:07:41 -06:00
34225e2bdf Use ensureAuthenticated as middleware 2020-11-04 17:07:40 -06:00
476379a77e Fix cookie domain
Had double Domain=
2020-11-04 17:07:39 -06:00
210fc049c4 Document VS Code endpoints 2020-11-04 17:07:39 -06:00
e5c8e0aad1 Remove useless || 2020-11-04 17:07:38 -06:00
c5ce365482 Use query variable to force update check 2020-11-04 17:07:37 -06:00
a653b93ce2 Include protocol on printed address
This makes it clickable from the terminal.
2020-11-04 17:07:36 -06:00
e2c35facdb Remove invalid comment on maybeProxy
It no longer handles authentication.
2020-11-04 17:07:35 -06:00
75b93f9dc5 Fix bind address priority
Broke when converting to a loop.
2020-11-04 17:07:24 -06:00
8066da12fe Remove unused Locals interface 2020-11-03 15:37:22 -06:00
03e0013112 Unbind error/exit events once handshakes resolve 2020-11-03 15:27:21 -06:00
e243f6e369 Return early when forking to reduce indentation 2020-11-03 15:27:21 -06:00
c10450c4c5 Move isFile into util
That allows its use in entry.ts as well.
2020-11-03 15:27:20 -06:00
c72c53f64d Fix not being able to dispose vscode after failed disposal 2020-11-03 14:36:27 -06:00
f4e5855318 Simplify update request 2020-11-03 14:35:23 -06:00
3a074fd844 Skip unnecessary auth type check when using --link 2020-11-03 14:30:34 -06:00
8a9e61defb Use Addr interface everywhere and loop over arg sources 2020-11-03 14:28:49 -06:00
1067507c41 Proxy to 0.0.0.0 instead of localhost 2020-11-03 14:28:48 -06:00
f2f1fee6f1 Short-circuit heartbeat when alive 2020-10-27 17:48:37 -05:00
504d89638b Fix open line being printed when open fails
Opening the URL can fail if the user doesn't have something appropriate
installed to handle it.
2020-10-27 17:43:11 -05:00
dc177ab505 Unambiguify address replacement
Co-authored-by: Teffen Ellis <TeffenEllis@users.noreply.github.com>
2020-10-27 17:38:54 -05:00
cde94d5ed4 Remove redundant serverAddress check
We now guarantee there is an address.
2020-10-27 17:35:42 -05:00
305348f0ac Improve proxy fallthrough logic
- Use accept header.
- Match /login and /login/ exactly.
- Match /static/ (trailing slash).
- Use req.path. Same result but feels more accurate to me.
2020-10-27 17:31:37 -05:00
6ab6cb4f07 Fix error handler types 2020-10-27 17:20:13 -05:00
6422a8d74b Fix webview resource path 2020-10-27 17:17:05 -05:00
257d9a4fa4 Make authentication work with sub-domain proxy 2020-10-26 17:56:14 -05:00
112eda4605 Convert routes to Express 2020-10-26 17:56:13 -05:00
4b6cbacbad Add file for global constants 2020-10-26 17:56:12 -05:00
71dc5c7542 Switch to Express
It doesn't do anything yet.
2020-10-26 17:56:11 -05:00
8e93e28162 Strip config file password from debug log 2020-10-20 16:18:28 -05:00
9f25cc6d5d Move providers from app to routes 2020-10-20 16:18:27 -05:00
6000e389bc Add Express as a dep and regenerate lockfile
The Express types were throwing errors but regenerating the lockfile
resolved them.
2020-10-20 16:18:26 -05:00
2928d362fa Move heart and AuthType out of http
This file is going to get blasted in favor of Express.
2020-10-20 16:18:24 -05:00
dcb303a437 Move argument defaults into setDefaults 2020-10-20 16:15:13 -05:00