Archived
1
0
Commit Graph

726 Commits

Author SHA1 Message Date
bf1be16d11 Fix base path
Now it should work whether you have a trailing slash or not.
2020-02-13 12:41:58 -06:00
cc79edb312 Fix duplicate files opening with folder parameter
Reworked from d574012871 to fit in the
new structure.
2020-02-13 12:04:22 -06:00
5baf16622f Fix VS Code product configuration not loading 2020-02-07 16:47:51 -06:00
256419004d Implement cli parser 2020-02-07 14:43:08 -06:00
26f8216ec8 Un-nest a switch 2020-02-06 14:00:38 -06:00
63f3c04c57 Move user data directory logic out of patch 2020-02-06 13:12:00 -06:00
8a0f1d846e Move start path logic out of patch and fix it 2020-02-06 12:29:38 -06:00
efaeb3b110 Add hidden username field for accessibility 2020-02-06 10:26:53 -06:00
6cebfa469d Generalize initial app logic 2020-02-05 18:47:00 -06:00
205775ac97 Only serve HTML on specific index.html requests
Otherwise there is risk of an infinite loop through the iframe where the
fallback keeps loading the root HTML which itself has an iframe...
2020-02-05 17:45:24 -06:00
4cc181cedc Make routing base path agnostic 2020-02-05 17:38:21 -06:00
6e809b6a31 Handle when VS Code fails to load
This is mostly for development where VS Code might not have finished
compiling yet.
2020-02-05 14:23:42 -06:00
7c6fe56043 Add logo to background 2020-02-05 13:30:29 -06:00
8cc11d1688 Improve routing 2020-02-05 13:07:07 -06:00
dbc5c065f8 Improve HTTP provider registration 2020-02-04 16:55:27 -06:00
b30aefcfb1 Add linting steps and improve testing steps 2020-02-04 15:42:55 -06:00
b29346ecdf Implement new structure 2020-02-04 14:31:44 -06:00
e6117decd0 Revert "Set display property in manifest to fullscreen"
This reverts commit c7127cb248.
2020-02-04 11:30:00 -06:00
c7127cb248 Set display property in manifest to fullscreen 2020-02-04 11:23:21 -06:00
8122b7f69e Remove unused upload service
No longer needed since VS Code has their own now.
2020-01-17 12:23:36 -06:00
e2d354c8f2 Move manifest icon to the root as well 2020-01-16 12:11:56 -06:00
7c178805ea Add comment about the manifest's served location
Also for #1278.
2020-01-16 11:44:17 -06:00
45f70e741f Move manifest to the root
Fixes #1278.
2020-01-16 11:36:17 -06:00
1474a82c7d Add insecure access notification 2020-01-16 11:15:22 -06:00
e6d1f2a7c8 Update VS Code to 1.41.0 2019-12-16 16:52:29 -06:00
e5fc63f2c8 Fix accessing manifest behind basic auth
Apparently the manifest spec doesn't include sending credentials in an
attempt to be secure by default.

Fixes #1212.
2019-12-09 11:25:59 -06:00
e14362f322 Pass along Node options 2019-11-14 17:20:23 -06:00
2018024810 Hash password
Fixes issues with unexpected characters breaking things when setting the
cookie (like semicolons).

This change as-is does not affect the security of code-server
itself (we've just replaced the static password with a static hash) but
if we were to add a salt in the future it would let us invalidate keys
by rehashing with a new salt which could be handy.
2019-11-07 15:57:57 -06:00
a1d6bcb8e5 Handle cookies more robustly
If you visit /login/ instead of /login the cookie will be set at /login
instead of / which means the cookie can't be read at the root. It will
redirect to the login page which *can* read the cookie at /login and
redirect back resulting in an infinite loop.

The previous solution relied on setting the cookie at / (any invalid
value works) which then overrode the login page cookie since
parseCookies only kept a single value. So the login page would see the
same cookie the root was seeing and not redirect back. However, that
behavior depends on the cookies being in the right order which I'm not
sure is guaranteed.

This new method tests all available cookies and always sets the cookie
so the root path will be able to read it in case the login page is
seeing a cookie the root can't.

It also goes a step further and explicitly sets the path on the cookie
which fixes the case where there is a permanent misconfiguration
redirecting /login to /login/. Otherwise the cookie would continually be
set on /login only and you'd have another loop. It also means you only
need to delete one cookie to log out.

Lastly add some properties to make the cookies a bit more secure.
2019-11-07 13:36:18 -06:00
727ac6483b Clear password when redirecting to login
Should prevent endless redirects when the cookie is set on a different path or domain (like with a dot prefix).
2019-11-07 11:38:10 -06:00
2c15c09fc0 Add missing telemetry option 2019-11-06 15:47:34 -06:00
780a673017 Add meta tag to allow full screen app on iOS
Fixes #933.
2019-11-04 16:01:01 -06:00
af71203955 Fix relaunching during an update 2019-11-01 10:51:23 -05:00
fc3acfabb2 Fix update check 2019-10-30 17:35:50 -05:00
73cf8f34e3 Fix outgoing scheme transformation
Accidentally used local instead of remote.

Fixes #1127.
2019-10-30 10:32:57 -05:00
87485948ad Kill inner process if parent process dies
Fixes #1076.
2019-10-29 14:43:27 -05:00
2f0878d9b7 Revert remote scheme change
It doesn't show in the explorer anymore so there's no point. Also remove
the local scheme transform which is no longer required with the latest
client-side extension implementation.
2019-10-29 11:26:50 -05:00
e22964915a Support opening workspaces from command line
Partly addresses #1121.
2019-10-28 16:25:51 -05:00
422503ef98 Proxy child exit code when exiting parent process
This fixes code-server exiting with zero on errors.
2019-10-28 14:57:01 -05:00
ea36345d2c Allow fetching any resource
Fixes #1118.
2019-10-28 14:29:51 -05:00
a89d83cbba Fix other incorrect usages of split 2019-10-28 14:03:13 -05:00
83ff31b620 Fix passwords that contain =
Fixes #1119.

Apparently `split` does not work the way I'd expect.
2019-10-28 13:47:31 -05:00
3a9b032c72 Add heartbeat file (#1115)
Fixes #1050.
2019-10-28 09:59:34 -05:00
f73e9225b4 Remove directory restrictions for /webview/vscode-resource
This makes viewing images work. Fixes #1111.
2019-10-25 15:52:39 -05:00
58f7f5b769 Properly fix blank --cert flag
See #1109.
2019-10-25 12:04:43 -05:00
b8e6369fbe Fix empty --cert not generating self-signed certificate
Fixes #1101.
2019-10-25 11:01:42 -05:00
95693fb58e Handle /webview/vscode-resource/file urls
See #1103.
2019-10-24 14:35:25 -05:00
e7945bea94 Enable password authentication by default
Fixes #1062.
2019-10-24 12:35:26 -05:00
eea9c1618c Move client-side extension code out of patch 2019-10-23 13:12:11 -05:00
ece840834d Move login page to browser directory
Fixes it not being included in the optimized build as well as making it
more consistent.
2019-10-21 15:02:41 -05:00