Avoid npx for Playwright dependencies (#4437)
It was causing version mismatch errors. It might make more sense to have this in the postinstall but for now I have foregone that as it would be installed in every step including those that do not run e2e tests.
This commit is contained in:
parent
13404df267
commit
dcc9cf3dd2
13
.github/workflows/ci.yaml
vendored
13
.github/workflows/ci.yaml
vendored
@ -378,9 +378,6 @@ jobs:
|
||||
with:
|
||||
node-version: "14"
|
||||
|
||||
- name: Install playwright OS dependencies
|
||||
run: npx playwright install-deps
|
||||
|
||||
- name: Fetch dependencies from cache
|
||||
id: cache-yarn
|
||||
uses: actions/cache@v2
|
||||
@ -406,14 +403,8 @@ jobs:
|
||||
if: steps.cache-yarn.outputs.cache-hit != 'true'
|
||||
run: yarn --frozen-lockfile
|
||||
|
||||
# HACK: this shouldn't need to exist, but put it here anyway
|
||||
# in an attempt to solve Playwright cache failures.
|
||||
- name: Reinstall playwright
|
||||
if: steps.cache-yarn.outputs.cache-hit == 'true'
|
||||
run: |
|
||||
cd test/
|
||||
rm -r node_modules/playwright
|
||||
yarn install --check-files
|
||||
- name: Install Playwright OS dependencies
|
||||
run: ./test/node_modules/.bin/playwright install-deps
|
||||
|
||||
- name: Run end-to-end tests
|
||||
run: yarn test:e2e
|
||||
|
Reference in New Issue
Block a user