From dcc9cf3dd2be5591b2e8c85fe21059c8ea1925ab Mon Sep 17 00:00:00 2001 From: Asher Date: Wed, 3 Nov 2021 16:17:43 -0500 Subject: [PATCH] Avoid npx for Playwright dependencies (#4437) It was causing version mismatch errors. It might make more sense to have this in the postinstall but for now I have foregone that as it would be installed in every step including those that do not run e2e tests. --- .github/workflows/ci.yaml | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 5c5e91fb9..0a52fc931 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -378,9 +378,6 @@ jobs: with: node-version: "14" - - name: Install playwright OS dependencies - run: npx playwright install-deps - - name: Fetch dependencies from cache id: cache-yarn uses: actions/cache@v2 @@ -406,14 +403,8 @@ jobs: if: steps.cache-yarn.outputs.cache-hit != 'true' run: yarn --frozen-lockfile - # HACK: this shouldn't need to exist, but put it here anyway - # in an attempt to solve Playwright cache failures. - - name: Reinstall playwright - if: steps.cache-yarn.outputs.cache-hit == 'true' - run: | - cd test/ - rm -r node_modules/playwright - yarn install --check-files + - name: Install Playwright OS dependencies + run: ./test/node_modules/.bin/playwright install-deps - name: Run end-to-end tests run: yarn test:e2e