Fix Set-CredentialStoreItem #76

Merged
OCram85 merged 7 commits from pinguinfuss/PSCredentialStore:Fix-Set-CredentialStoreItem into master 4 months ago

📖 Summary

  • Fix Set-CredentialStoreItem. Currently it doesn't warn if the user is trying to update a CredentialStoreItem, that does not exist.
  • Also add a bit of documentation and UnitTests.
  • Fix the quotation of Test-CredentialStoreItem.

📑 Test Plan

💡 Select your test plan for the code changes.

  • Tested via Drone.io pipeline
  • Custom test
  • No test plan
Details / Justification

📚 Additional Notes

#### :book: Summary - Fix Set-CredentialStoreItem. Currently it doesn't warn if the user is trying to update a CredentialStoreItem, that does not exist. - Also add a bit of documentation and UnitTests. - Fix the quotation of Test-CredentialStoreItem. #### :bookmark_tabs: Test Plan > :bulb: Select your test plan for the code changes. - [x] Tested via Drone.io pipeline - [ ] Custom test - [ ] No test plan ##### Details / Justification <!-- Add your test details or justification for missing tests here. --> #### :books: Additional Notes <!-- A place for additional detail notes. -->
pinguinfuss added 5 commits 4 months ago
OCram85 requested review from OCram85 4 months ago
OCram85 added the
bug
label 4 months ago
OCram85 added this to the v1.1.1 milestone 4 months ago
OCram85 added 1 commit 4 months ago
OCram85 approved these changes 4 months ago
OCram85 left a comment
Owner

🚀 lgtm

:rocket: lgtm
OCram85 added 1 commit 4 months ago
Collaborator

Drone.io PR Build No. #122: success

/drone/src/build/FileLinter-Results.log

✔️ No FileLinter violations in 31 files found.

/drone/src/build/Pester-Results.log

Result Test Duration
⚠️ Test-CredentialStore.Basic logic tests.Read a broken CredentialStore 0ms

🧪 51 Total Tests (✔️ 50 Passed ▫️🔱 1 Skipped / NotRun ▫️ ⚠️ Unknown ▫️ 0 Failed)
📑 Covered 42.69% / 75%. (🔖 787 analyzed Commands 📄 in 25 Files)

/drone/src/build/ScriptAnalyzer-Results.log

✔️ No violations found.

end.

> Drone.io PR Build No. [#122](https://drone.ocram85.com/OCram85/PSCredentialStore/122): ``success`` #### ``/drone/src/build/FileLinter-Results.log`` :heavy_check_mark: No FileLinter violations in 31 files found. #### ``/drone/src/build/Pester-Results.log`` | Result | Test | Duration | | :----: | :--- | -------: | | :warning: | `Test-CredentialStore.Basic logic tests.Read a broken CredentialStore` | *0ms* | :test_tube: **51** Total Tests (:heavy_check_mark: ``50 Passed`` :white_small_square::trident: ``1 Skipped / NotRun`` :white_small_square: :warning: ``Unknown`` :white_small_square: :heavy_exclamation_mark: ``0 Failed``) :bookmark_tabs: Covered **42.69%** / 75%. (:bookmark: ``787 analyzed Commands`` :page_facing_up: ``in 25 Files``) #### ``/drone/src/build/ScriptAnalyzer-Results.log`` :heavy_check_mark: No violations found. end.
OCram85 merged commit 42fdb0a373 into master 4 months ago
OCram85 deleted branch Fix-Set-CredentialStoreItem 4 months ago
OCram85 referenced this issue from a commit 4 months ago

Reviewers

OCram85 approved these changes 4 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 42fdb0a373.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OCram85/PSCredentialStore#76
Loading…
There is no content yet.