Fix Set-CredentialStoreItem #76

Merged

OCram85 merged 7 commits from pinguinfuss/PSCredentialStore:Fix-Set-CredentialStoreItem into master 2022-10-10 10:05:08 +02:00

Conversation 2 Commits 7 Files Changed 3 +179 -20

pinguinfuss commented 2022-10-06 21:53:17 +02:00

Contributor

Copy Link

📖 Summary

• Fix Set-CredentialStoreItem. Currently it doesn't warn if the user is trying to update a CredentialStoreItem, that does not exist.
• Also add a bit of documentation and UnitTests.
• Fix the quotation of Test-CredentialStoreItem.

📑 Test Plan

💡 Select your test plan for the code changes.

• Tested via Drone.io pipeline
• Custom test
• No test plan

Details / Justification

📚 Additional Notes

#### :book: Summary - Fix Set-CredentialStoreItem. Currently it doesn't warn if the user is trying to update a CredentialStoreItem, that does not exist. - Also add a bit of documentation and UnitTests. - Fix the quotation of Test-CredentialStoreItem. #### :bookmark_tabs: Test Plan > :bulb: Select your test plan for the code changes. - [x] Tested via Drone.io pipeline - [ ] Custom test - [ ] No test plan ##### Details / Justification <!-- Add your test details or justification for missing tests here. --> #### :books: Additional Notes <!-- A place for additional detail notes. -->

pinguinfuss added 5 commits 2022-10-06 21:53:17 +02:00

Write a error message if we cannot locate the CredentialStoreItem in the Store. Fix string quotation a36b53c1a5

Fix string quotation c086015272

We need to always set -Shared (even if we have to set it to $false) 90f82b137d

Add unit tests for Set-CredentialStoreItem 025f18725b

Fix quotation d19278c99d

OCram85 requested review from OCram85 2022-10-07 09:04:24 +02:00

OCram85 added the

bug

label 2022-10-07 09:04:29 +02:00

OCram85 added this to the v1.1.1 milestone 2022-10-10 09:41:38 +02:00

OCram85 added 1 commit 2022-10-10 09:42:39 +02:00

Merge branch 'master' into Fix-Set-CredentialStoreItem 44fdf38c1d

OCram85 approved these changes 2022-10-10 09:46:44 +02:00

OCram85 left a comment

Owner

Copy Link

🚀 lgtm

:rocket: lgtm

OCram85 added 1 commit 2022-10-10 10:01:12 +02:00

Merge branch 'master' into Fix-Set-CredentialStoreItem 1717c19357

ci-bot commented 2022-10-10 10:04:09 +02:00

Collaborator

Copy Link

Drone.io PR Build No. #122: success

/drone/src/build/FileLinter-Results.log

✔️ No FileLinter violations in 31 files found.

/drone/src/build/Pester-Results.log

Result	Test	Duration
⚠️	Test-CredentialStore.Basic logic tests.Read a broken CredentialStore	0ms

🧪 51 Total Tests (✔️ 50 Passed ▫️🔱 1 Skipped / NotRun ▫️ ⚠️ Unknown ▫️ ❗ 0 Failed)
📑 Covered 42.69% / 75%. (🔖 787 analyzed Commands 📄 in 25 Files)

/drone/src/build/ScriptAnalyzer-Results.log

✔️ No violations found.

end.

> Drone.io PR Build No. [#122](https://drone.ocram85.com/OCram85/PSCredentialStore/122): ``success`` #### ``/drone/src/build/FileLinter-Results.log`` :heavy_check_mark: No FileLinter violations in 31 files found. #### ``/drone/src/build/Pester-Results.log`` | Result | Test | Duration | | :----: | :--- | -------: | | :warning: | `Test-CredentialStore.Basic logic tests.Read a broken CredentialStore` | *0ms* | :test_tube: **51** Total Tests (:heavy_check_mark: ``50 Passed`` :white_small_square::trident: ``1 Skipped / NotRun`` :white_small_square: :warning: ``Unknown`` :white_small_square: :heavy_exclamation_mark: ``0 Failed``) :bookmark_tabs: Covered **42.69%** / 75%. (:bookmark: ``787 analyzed Commands`` :page_facing_up: ``in 25 Files``) #### ``/drone/src/build/ScriptAnalyzer-Results.log`` :heavy_check_mark: No violations found. end.

OCram85 merged commit 42fdb0a373 into master 2022-10-10 10:05:08 +02:00

OCram85 deleted branch Fix-Set-CredentialStoreItem 2022-10-10 10:05:08 +02:00

OCram85 referenced this issue from a commit 2022-10-10 10:05:08 +02:00

Fix Set-CredentialStoreItem (#76)

Sign in to join this conversation.

Reviewers

No Reviewers

OCram85

Labels

Clear labels

bug

Something is not working

docs

Changes related to the docs output

duplicate

This issue or pull request already exists

enhancement

New feature

feature

Adds a new feature

help wanted

Need some help

invalid

Something is wrong

meta

Changes related to general project files

question

More information is needed

wontfix

This won't be fixed

No Label

bug

Milestone

No items

No Milestone v1.1.1

Assignees

Clear assignees

ci-bot OCram85

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OCram85/PSCredentialStore#76

No description provided.