Labels Milestones

Fix optional module dependencies #75

Merged

OCram85 merged 2 commits from pinguinfuss/PSCredentialStore:Fix-Optional-Dependencies into master 8 months ago

Conversation 1 Commits 2 Files Changed 1

pinguinfuss commented 8 months ago

📖 Summary

• Fix the optional dependencies.
  • DataONTAP was never a PSGallery module, and we have to custom build that.
  • NetApp finally submitted NetApp.ONTAP into PSGallery, so we can depend on that.
• Updates UCS- and VMware-modules.

📑 Test Plan

💡 Select your test plan for the code changes.

• Tested via Drone.io pipeline
• Custom test
• No test plan

Details / Justification

Sadly, you have to run it. The module loader does not have a unit test.

📚 Additional Notes

#### :book: Summary - Fix the optional dependencies. - DataONTAP was never a PSGallery module, and we have to custom build that. - NetApp finally submitted NetApp.ONTAP into PSGallery, so we can depend on that. - Updates UCS- and VMware-modules. #### :bookmark_tabs: Test Plan > :bulb: Select your test plan for the code changes. - [ ] Tested via Drone.io pipeline - [ ] Custom test - [x] No test plan ##### Details / Justification Sadly, you have to run it. The module loader does not have a unit test. #### :books: Additional Notes <!-- A place for additional detail notes. -->

pinguinfuss added 1 commit 8 months ago

44c9a0eb7d Fix the module dependencies for Cisco.UCSManager and DataONTAP/NetApp.ONTAP

OCram85 added the bug label 8 months ago

OCram85 requested review from OCram85 8 months ago

OCram85 added this to the v1.1.1 milestone 8 months ago

OCram85 changed title from Fix the module dependencies for Cisco.UCSManager and DataONTAP/NetApp.ONTAP to Fix optional module dependencies 8 months ago

OCram85 added 1 commit 8 months ago

60573a76e4 Merge branch 'master' into Fix-Optional-Dependencies

OCram85 added the enhancement label 8 months ago

OCram85 approved these changes 8 months ago

OCram85 left a comment

Owner

🚀 lgtm

:rocket: lgtm

ci-bot commented 8 months ago

Collaborator

Drone.io PR Build No. #117: success

/drone/src/build/FileLinter-Results.log

✔️ No FileLinter violations in 31 files found.

/drone/src/build/Pester-Results.log

Result	Test	Duration
⚠️	Test-CredentialStore.Basic logic tests.Read a broken CredentialStore	0ms

🧪 49 Total Tests (✔️ 48 Passed ▫️🔱 1 Skipped / NotRun ▫️ ⚠️ Unknown ▫️ ❗ 0 Failed)
📑 Covered 38.77% / 75%. (🔖 779 analyzed Commands 📄 in 25 Files)

/drone/src/build/ScriptAnalyzer-Results.log

✔️ No violations found.

end.

> Drone.io PR Build No. [#117](https://drone.ocram85.com/OCram85/PSCredentialStore/117): ``success`` #### ``/drone/src/build/FileLinter-Results.log`` :heavy_check_mark: No FileLinter violations in 31 files found. #### ``/drone/src/build/Pester-Results.log`` | Result | Test | Duration | | :----: | :--- | -------: | | :warning: | `Test-CredentialStore.Basic logic tests.Read a broken CredentialStore` | *0ms* | :test_tube: **49** Total Tests (:heavy_check_mark: ``48 Passed`` :white_small_square::trident: ``1 Skipped / NotRun`` :white_small_square: :warning: ``Unknown`` :white_small_square: :heavy_exclamation_mark: ``0 Failed``) :bookmark_tabs: Covered **38.77%** / 75%. (:bookmark: ``779 analyzed Commands`` :page_facing_up: ``in 25 Files``) #### ``/drone/src/build/ScriptAnalyzer-Results.log`` :heavy_check_mark: No violations found. end.

OCram85 merged commit 2bd250971b into master 8 months ago

OCram85 deleted branch Fix-Optional-Dependencies 8 months ago

OCram85 referenced this issue from a commit 8 months ago

Fix optional module dependencies (#75)

Reviewers

OCram85 approved these changes 8 months ago

continuous-integration/drone/pr Build is passing

Details

The pull request has been merged as 2bd250971b.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

OCram85

Labels

Apply labels

Clear labels

bug
Something is not working docs
Changes related to the docs output duplicate
This issue or pull request already exists enhancement
New feature feature
Adds a new feature help wanted
Need some help invalid
Something is wrong meta
Changes related to general project files question
More information is needed wontfix
This won't be fixed

No Label bug docs duplicate enhancement feature help wanted invalid meta question wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

v1.1.1

Assignees

Assign users

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: OCram85/PSCredentialStore#75

Write Preview

Loading…

Cancel

Save

There is no content yet.