Fix optional module dependencies #75

pinguinfuss · 2022-10-06T21:48:04+02:00

pinguinfuss commented

2022-10-06 21:48:04 +02:00

📖 Summary

Fix the optional dependencies.
- DataONTAP was never a PSGallery module, and we have to custom build that.
- NetApp finally submitted NetApp.ONTAP into PSGallery, so we can depend on that.
Updates UCS- and VMware-modules.

📑 Test Plan

💡 Select your test plan for the code changes.

Tested via Drone.io pipeline
Custom test
No test plan

Details / Justification

Sadly, you have to run it. The module loader does not have a unit test.

📚 Additional Notes

#### :book: Summary - Fix the optional dependencies. - DataONTAP was never a PSGallery module, and we have to custom build that. - NetApp finally submitted NetApp.ONTAP into PSGallery, so we can depend on that. - Updates UCS- and VMware-modules. #### :bookmark_tabs: Test Plan > :bulb: Select your test plan for the code changes. - [ ] Tested via Drone.io pipeline - [ ] Custom test - [x] No test plan ##### Details / Justification Sadly, you have to run it. The module loader does not have a unit test. #### :books: Additional Notes

pinguinfuss added 1 commit 2022-10-06 21:48:05 +02:00

Fix the module dependencies for Cisco.UCSManager and DataONTAP/NetApp.ONTAP

continuous-integration/drone/pr Build is passing

Details

44c9a0eb7d

OCram85 added the

bug

label 2022-10-07 09:00:57 +02:00

OCram85 requested review from OCram85 2022-10-07 09:04:44 +02:00

OCram85 added this to the v1.1.1 milestone 2022-10-10 09:41:48 +02:00

OCram85 changed title from ~~Fix the module dependencies for Cisco.UCSManager and DataONTAP/NetApp.ONTAP~~ to Fix optional module dependencies

2022-10-10 09:48:58 +02:00

OCram85 added 1 commit 2022-10-10 09:50:02 +02:00

Merge branch 'master' into Fix-Optional-Dependencies

continuous-integration/drone/pr Build is passing

Details

60573a76e4

OCram85 added the

enhancement

label 2022-10-10 09:50:26 +02:00

OCram85 approved these changes 2022-10-10 09:51:19 +02:00

OCram85 left a comment

🚀 lgtm

:rocket: lgtm

ci-bot commented

2022-10-10 09:51:23 +02:00

Drone.io PR Build No. #117: success

`/drone/src/build/FileLinter-Results.log`

✔️ No FileLinter violations in 31 files found.

`/drone/src/build/Pester-Results.log`

Result	Test	Duration
⚠️	`Test-CredentialStore.Basic logic tests.Read a broken CredentialStore`	0ms

🧪 49 Total Tests (✔️ 48 Passed ▫️🔱 1 Skipped / NotRun ▫️ ⚠️ Unknown ▫️ ❗ 0 Failed)
📑 Covered 38.77% / 75%. (🔖 779 analyzed Commands 📄 in 25 Files)

`/drone/src/build/ScriptAnalyzer-Results.log`

✔️ No violations found.

end.

> Drone.io PR Build No. [#117](https://drone.ocram85.com/OCram85/PSCredentialStore/117): ``success`` #### ``/drone/src/build/FileLinter-Results.log`` :heavy_check_mark: No FileLinter violations in 31 files found. #### ``/drone/src/build/Pester-Results.log`` | Result | Test | Duration | | :----: | :--- | -------: | | :warning: | `Test-CredentialStore.Basic logic tests.Read a broken CredentialStore` | *0ms* | :test_tube: **49** Total Tests (:heavy_check_mark: ``48 Passed`` :white_small_square::trident: ``1 Skipped / NotRun`` :white_small_square: :warning: ``Unknown`` :white_small_square: :heavy_exclamation_mark: ``0 Failed``) :bookmark_tabs: Covered **38.77%** / 75%. (:bookmark: ``779 analyzed Commands`` :page_facing_up: ``in 25 Files``) #### ``/drone/src/build/ScriptAnalyzer-Results.log`` :heavy_check_mark: No violations found. end.

OCram85 merged commit 2bd250971b into master

2022-10-10 10:00:43 +02:00

OCram85 deleted branch Fix-Optional-Dependencies

2022-10-10 10:00:43 +02:00

OCram85 referenced this issue from a commit

2022-10-10 10:00:43 +02:00

Fix optional module dependencies (#75)

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OCram85/PSCredentialStore#75