tabs or spaces

This commit is contained in:
Bryan MacFarlane 2020-03-30 10:46:01 -04:00
parent 89c89c5036
commit e36ce1d6cf
2 changed files with 12 additions and 12 deletions

View File

@ -379,7 +379,7 @@ describe('setup-go', () => {
expect(annotation.message).toBe('missing return at end of function'); expect(annotation.message).toBe('missing return at end of function');
}); });
it('matches on unix path with whitespace', async () => { it('matches on unix path with spaces', async () => {
let line = ' ./assert.go:5:2: missing return at end of function '; let line = ' ./assert.go:5:2: missing return at end of function ';
let annotation = testMatch(line); let annotation = testMatch(line);
expect(annotation).toBeDefined(); expect(annotation).toBeDefined();
@ -389,6 +389,16 @@ describe('setup-go', () => {
expect(annotation.message).toBe('missing return at end of function'); expect(annotation.message).toBe('missing return at end of function');
}); });
it('matches on unix path with tabs', async () => {
let line = '\t./assert.go:5:2: missing return at end of function ';
let annotation = testMatch(line);
expect(annotation).toBeDefined();
expect(annotation.line).toBe(5);
expect(annotation.column).toBe(2);
expect(annotation.file).toBe('./assert.go');
expect(annotation.message).toBe('missing return at end of function');
});
it('matches on relative windows path', async () => { it('matches on relative windows path', async () => {
let line = '.\\main.go:13:2: undefined: fmt.Printl'; let line = '.\\main.go:13:2: undefined: fmt.Printl';
let annotation = testMatch(line); let annotation = testMatch(line);
@ -409,16 +419,6 @@ describe('setup-go', () => {
expect(annotation.message).toBe('undefined: fmt.Printl'); expect(annotation.message).toBe('undefined: fmt.Printl');
}); });
it('only matches leading dots on unix path', async () => {
let line = 'x./assert.go:5:2: missing return at end of function';
let annotation = testMatch(line);
expect(annotation).toBeDefined();
expect(annotation.line).toBe(5);
expect(annotation.column).toBe(2);
expect(annotation.file).toBe('./assert.go');
expect(annotation.message).toBe('missing return at end of function');
});
// 1.13.1 => 1.13.1 // 1.13.1 => 1.13.1
// 1.13 => 1.13.0 // 1.13 => 1.13.0
// 1.10beta1 => 1.10.0-beta1, 1.10rc1 => 1.10.0-rc1 // 1.10beta1 => 1.10.0-beta1, 1.10rc1 => 1.10.0-rc1

View File

@ -4,7 +4,7 @@
"owner": "go", "owner": "go",
"pattern": [ "pattern": [
{ {
"regexp": "(\\.{0,2}[\\/\\\\].+\\.go):(?:(\\d+):(\\d+):)? (.*)", "regexp": "^\\s*(\\.{0,2}[\\/\\\\].+\\.go):(?:(\\d+):(\\d+):)? (.*)",
"file": 1, "file": 1,
"line": 2, "line": 2,
"column": 3, "column": 3,