9e583fa562
The problem before was that the pop() caused the open in existing instance functionality to break because the arguments no longer contained the file. We could simply remove the pop() but since `workspace` and `folder` are not CLI arguments I think it makes sense to handle them in a separate function which can be called at the point where they are needed. This also lets us de-duplicate some logic since we create these arguments in two spots and lets us skip this logic when we do not need it. The pop() is still avoided because manipulating a passed-in object in-place seems like a risky move. If we really need to do this we should copy the positional argument array instead. |
||
|---|---|---|
| .. | ||
| __snapshots__ | ||
| routes | ||
| test-plugin | ||
| app.test.ts | ||
| cli.test.ts | ||
| constants.test.ts | ||
| http.test.ts | ||
| plugin.test.ts | ||
| proxy_agent.test.ts | ||
| proxy.test.ts | ||
| socket.test.ts | ||
| update.test.ts | ||
| util.test.ts | ||