705e821741
* fix(testing): revert change & fix playwright tests * fix(constants): add type to import statement * refactor(e2e): delete browser test This test was originally added to ensure playwright was working. At this point, we know it works so removing this test because it doesn't help with anything specific to code-server and only adds unnecessary code to the codebase plus increases the e2e test job duration. * chore(e2e): use 1 worker for e2e test I don't know if it's a resources issue, playwright, or code-server but it seems like the e2e tests choke when multiple workers are used. This change is okay because our CI runner only has 2 cores so it would only use 1 worker anyway, but by specifying it in our playwright config, we ensure more stability in our e2e tests working correctly. See these PRs: - https://github.com/cdr/code-server/pull/3263 - https://github.com/cdr/code-server/pull/4310 * revert(vscode): add missing route with redirect * chore(vscode): update to latest fork * Touch up compilation step. * Bump vendor. * Fix VS Code minification step * Move ClientConfiguration to common Common code must not import Node code as it is imported by the browser. * Ensure lib directory exists before curling cURL errors now because VS Code was moved and the directory does not exist. * Update incorrect e2e test help output Revert workers change as well; this can be overridden when desired. * Add back extension compilation step * Include missing resources in release This includes a favicon, for example. I opted to include the entire directory to make sure we do not miss anything. Some of the other stuff looks potentially useful (like completions). * Set quality property in product configuration When httpWebWorkerExtensionHostIframe.html is fetched it uses the web endpoint template (in which we do not include the commit) but if the quality is not set it prepends the commit to the web endpoint instead. The new static endpoint does not use/handle commits so this 404s. Long-term we might want to make the new static endpoint use commits like the old one but we will also need to update the various other static URLs to include the commit. For now I just fixed this by adding the quality since: 1. Probably faster than trying to find and update all static uses. 2. VS Code probably expects it anyway. 3. Gives us better control over the endpoint. * Update VS Code This fixes several build issues. * Bump vscode. * Bump. * Bump. * Use CLI directly. * Update tests to reflect new upstream behavior. * Move unit tests to after the build Our code has new dependencies on VS Code that are pulled in when the unit tests run. Because of this we need to build VS Code before running the unit tests (as it only pulls built code). * Upgrade proxy-agent dependencies This resolves a security report with one of its dependencies (vm2). * Symlink VS Code output directory before unit tests This is necessary now that we import from the out directory. * Fix issues surrounding persistent processes between tests. * Update VS Code cache directories These were renamed so the cached paths need to be updated. I changed the key as well to force a rebuild. * Move test symlink to script This way it works for local testing as well. I had to use out-build instead of out-vscode-server-min because Jest throws some obscure error about a handlebars haste map. * Fix listening on a socket * Update VS Code It contains fixes for missing files in the build. * Standardize disposals * Dispose HTTP server Shares code with the test HTTP server. For now it is a function but maybe we should make it a class that is extended by tests. * Dispose app on exit * Fix logging link errors Unfortunately the logger currently chokes when provided with error objects. Also for some reason the bracketed text was not displaying... * Update regex used by e2e to extract address The address was recently changed to use URL which seems to add a trailing slash when using toString, causing the regex match to fail. * Log browser console in e2e tests * Add base back to login page This is used to set cookies when using a base path. * Remove login page test The file this was testing no longer exists. * Use path.posix for static base Since this is a web path and not platform-dependent. * Add test for invalid password Co-authored-by: Teffen Ellis <teffen@nirri.us> Co-authored-by: Asher <ash@coder.com>
205 lines
6.8 KiB
TypeScript
205 lines
6.8 KiB
TypeScript
import { field, logger } from "@coder/logger"
|
|
import { ChildProcessWithoutNullStreams } from "child_process"
|
|
import http from "http"
|
|
import path from "path"
|
|
import { Disposable } from "../common/emitter"
|
|
import { plural, logError } from "../common/util"
|
|
import { createApp, ensureAddress } from "./app"
|
|
import { AuthType, DefaultedArgs, Feature } from "./cli"
|
|
import { coderCloudBind } from "./coder_cloud"
|
|
import { commit, version, vsRootPath } from "./constants"
|
|
import { startLink } from "./link"
|
|
import { register } from "./routes"
|
|
import { humanPath, isFile, loadAMDModule, open } from "./util"
|
|
|
|
export const shouldSpawnCliProcess = async (args: CodeServerLib.NativeParsedArgs): Promise<boolean> => {
|
|
const shouldSpawn = await loadAMDModule<(argv: CodeServerLib.NativeParsedArgs) => boolean>(
|
|
"vs/code/node/cli",
|
|
"shouldSpawnCliProcess",
|
|
)
|
|
|
|
return shouldSpawn(args)
|
|
}
|
|
|
|
/**
|
|
* This is useful when an CLI arg should be passed to VS Code directly,
|
|
* such as when managing extensions.
|
|
* @deprecated This should be removed when code-server merges with lib/vscode.
|
|
*/
|
|
export const runVsCodeCli = async (): Promise<void> => {
|
|
logger.debug("Running VS Code CLI")
|
|
|
|
// Delete `VSCODE_CWD` very early even before
|
|
// importing bootstrap files. We have seen
|
|
// reports where `code .` would use the wrong
|
|
// current working directory due to our variable
|
|
// somehow escaping to the parent shell
|
|
// (https://github.com/microsoft/vscode/issues/126399)
|
|
delete process.env["VSCODE_CWD"]
|
|
|
|
const bootstrap = require(path.join(vsRootPath, "out", "bootstrap"))
|
|
const bootstrapNode = require(path.join(vsRootPath, "out", "bootstrap-node"))
|
|
const product = require(path.join(vsRootPath, "product.json"))
|
|
|
|
// Avoid Monkey Patches from Application Insights
|
|
bootstrap.avoidMonkeyPatchFromAppInsights()
|
|
|
|
// Enable portable support
|
|
bootstrapNode.configurePortable(product)
|
|
|
|
// Enable ASAR support
|
|
bootstrap.enableASARSupport()
|
|
|
|
// Signal processes that we got launched as CLI
|
|
process.env["VSCODE_CLI"] = "1"
|
|
|
|
const cliProcessMain = await loadAMDModule<CodeServerLib.IMainCli["main"]>("vs/code/node/cli", "initialize")
|
|
|
|
try {
|
|
await cliProcessMain(process.argv)
|
|
} catch (error: any) {
|
|
logger.error("Got error from VS Code", error)
|
|
}
|
|
|
|
process.exit(0)
|
|
}
|
|
|
|
export const openInExistingInstance = async (args: DefaultedArgs, socketPath: string): Promise<void> => {
|
|
const pipeArgs: CodeServerLib.OpenCommandPipeArgs & { fileURIs: string[] } = {
|
|
type: "open",
|
|
folderURIs: [],
|
|
fileURIs: [],
|
|
forceReuseWindow: args["reuse-window"],
|
|
forceNewWindow: args["new-window"],
|
|
}
|
|
for (let i = 0; i < args._.length; i++) {
|
|
const fp = path.resolve(args._[i])
|
|
if (await isFile(fp)) {
|
|
pipeArgs.fileURIs.push(fp)
|
|
} else {
|
|
pipeArgs.folderURIs.push(fp)
|
|
}
|
|
}
|
|
if (pipeArgs.forceNewWindow && pipeArgs.fileURIs.length > 0) {
|
|
logger.error("--new-window can only be used with folder paths")
|
|
process.exit(1)
|
|
}
|
|
if (pipeArgs.folderURIs.length === 0 && pipeArgs.fileURIs.length === 0) {
|
|
logger.error("Please specify at least one file or folder")
|
|
process.exit(1)
|
|
}
|
|
const vscode = http.request(
|
|
{
|
|
path: "/",
|
|
method: "POST",
|
|
socketPath,
|
|
},
|
|
(response) => {
|
|
response.on("data", (message) => {
|
|
logger.debug("got message from VS Code", field("message", message.toString()))
|
|
})
|
|
},
|
|
)
|
|
vscode.on("error", (error: unknown) => {
|
|
logger.error("got error from VS Code", field("error", error))
|
|
})
|
|
vscode.write(JSON.stringify(pipeArgs))
|
|
vscode.end()
|
|
}
|
|
|
|
export const runCodeServer = async (
|
|
args: DefaultedArgs,
|
|
): Promise<{ dispose: Disposable["dispose"]; server: http.Server }> => {
|
|
logger.info(`code-server ${version} ${commit}`)
|
|
|
|
logger.info(`Using user-data-dir ${humanPath(args["user-data-dir"])}`)
|
|
logger.trace(`Using extensions-dir ${humanPath(args["extensions-dir"])}`)
|
|
|
|
if (args.auth === AuthType.Password && !args.password && !args["hashed-password"]) {
|
|
throw new Error(
|
|
"Please pass in a password via the config file or environment variable ($PASSWORD or $HASHED_PASSWORD)",
|
|
)
|
|
}
|
|
|
|
const app = await createApp(args)
|
|
const serverAddress = ensureAddress(app.server, args.cert ? "https" : "http")
|
|
const disposeRoutes = await register(app, args)
|
|
|
|
logger.info(`Using config file ${humanPath(args.config)}`)
|
|
logger.info(`HTTP server listening on ${serverAddress.toString()} ${args.link ? "(randomized by --link)" : ""}`)
|
|
if (args.auth === AuthType.Password) {
|
|
logger.info(" - Authentication is enabled")
|
|
if (args.usingEnvPassword) {
|
|
logger.info(" - Using password from $PASSWORD")
|
|
} else if (args.usingEnvHashedPassword) {
|
|
logger.info(" - Using password from $HASHED_PASSWORD")
|
|
} else {
|
|
logger.info(` - Using password from ${humanPath(args.config)}`)
|
|
}
|
|
} else {
|
|
logger.info(` - Authentication is disabled ${args.link ? "(disabled by --link)" : ""}`)
|
|
}
|
|
|
|
if (args.cert) {
|
|
logger.info(` - Using certificate for HTTPS: ${humanPath(args.cert.value)}`)
|
|
} else {
|
|
logger.info(` - Not serving HTTPS ${args.link ? "(disabled by --link)" : ""}`)
|
|
}
|
|
|
|
if (args["proxy-domain"].length > 0) {
|
|
logger.info(` - ${plural(args["proxy-domain"].length, "Proxying the following domain")}:`)
|
|
args["proxy-domain"].forEach((domain) => logger.info(` - *.${domain}`))
|
|
}
|
|
|
|
if (args.link) {
|
|
await coderCloudBind(serverAddress, args.link.value)
|
|
logger.info(" - Connected to cloud agent")
|
|
}
|
|
|
|
let linkAgent: undefined | ChildProcessWithoutNullStreams
|
|
try {
|
|
linkAgent = startLink(serverAddress)
|
|
linkAgent.on("error", (error) => {
|
|
logError(logger, "link daemon", error)
|
|
})
|
|
linkAgent.on("close", (code) => {
|
|
logger.debug("link daemon closed", field("code", code))
|
|
})
|
|
} catch (error) {
|
|
logError(logger, "link daemon", error)
|
|
}
|
|
|
|
if (args.enable && args.enable.length > 0) {
|
|
logger.info("Enabling the following experimental features:")
|
|
args.enable.forEach((feature) => {
|
|
if (Object.values(Feature).includes(feature as Feature)) {
|
|
logger.info(` - "${feature}"`)
|
|
} else {
|
|
logger.error(` X "${feature}" (unknown feature)`)
|
|
}
|
|
})
|
|
// TODO: Could be nice to add wrapping to the logger?
|
|
logger.info(
|
|
" The code-server project does not provide stability guarantees or commit to fixing bugs relating to these experimental features. When filing bug reports, please ensure that you can reproduce the bug with all experimental features turned off.",
|
|
)
|
|
}
|
|
|
|
if (args.open) {
|
|
try {
|
|
await open(serverAddress)
|
|
logger.info(`Opened ${serverAddress}`)
|
|
} catch (error) {
|
|
logger.error("Failed to open", field("address", serverAddress.toString()), field("error", error))
|
|
}
|
|
}
|
|
|
|
return {
|
|
server: app.server,
|
|
dispose: async () => {
|
|
linkAgent?.kill()
|
|
disposeRoutes()
|
|
await app.dispose()
|
|
},
|
|
}
|
|
}
|