Asher
95ef6dbf2f
Remove unused wrapper options
...
Also move our memory default to the beginning of NODE_OPTIONS so it can
be overidden. The version of the flag with dashes seems to be the more
correct one now so use that instead of underscores.
Related: #2113 .
2020-11-18 13:23:06 -06:00
Asher
016daf2fdd
Parse arguments once
...
Fixes #2316 .
2020-11-18 13:01:46 -06:00
Asher
247c4ec776
Move onMessage so it can be used in the wrappers
2020-11-18 12:28:43 -06:00
Asher
d55e06936b
Split child and parent wrappers
...
I think having them combined and relying on if statements was getting
confusing especially if we want to add additional messages with
different payloads (which will soon be the case).
2020-11-18 12:28:42 -06:00
Asher
2a3608df53
Skip heartbeat on /healthz endpoint ( #2333 )
...
I managed to lose this in the rewrite.
Fixes #2327 .
2020-11-18 12:19:08 -06:00
piousdeer
c6062c3d0a
Fix log message ( #2331 )
2020-11-18 10:41:32 -06:00
Anmol Sethi
9ff535eddc
Merge pull request #2312 from cdr/v3.7.1
...
v3.7.1
2020-11-16 18:14:15 -05:00
Anmol Sethi
2bf91ff6a6
v3.7.1
2020-11-16 17:18:12 -05:00
Anmol Sethi
ccc519ecbd
ci: Pin nfpm to v1.9.0
...
Closes #2310
2020-11-16 16:57:04 -05:00
Anmol Sethi
40e1f066ff
ci: Improve release template ( #2311 )
2020-11-16 16:56:53 -05:00
Anmol Sethi
ac09aa6ea8
doc/ipad.md: Fix TOC
2020-11-16 15:40:28 -05:00
Anmol Sethi
f5e3dca3b9
Merge pull request #2309 from cdr/v3.7.0
...
v3.7.0
2020-11-16 15:33:17 -05:00
Anmol Sethi
f64599b94d
ci: Update standalone build test
...
ms-toolsai.jupyter is now a dependency of ms-python and is installed
along with it.
2020-11-16 14:40:06 -05:00
Anmol Sethi
9917da068a
v3.7.0
2020-11-16 11:11:50 -05:00
Anmol Sethi
8bf1bf2c9f
helm: Use upgrade --install everywhere
...
See @sreya's review
2020-11-13 18:45:13 -05:00
Anmol Sethi
79e8f3dfdb
ci: Only use helm kubeval if installed
2020-11-13 18:44:29 -05:00
Anmol Sethi
a37572d92d
ci: Disable no-unused-vars for function args
...
See previous commit for failure introduced.
2020-11-13 18:44:28 -05:00
Anmol Sethi
40a7c11ce3
node/routes: Fix error handling
...
We should always send HTML if the user agent expects it.
If they do not, they should clearly indicate such via the Accept header.
Closes #2297
2020-11-13 18:44:28 -05:00
Anmol Sethi
7afa689285
Merge pull request #2303 from cdr/helm-db7f
...
Move helm from root and fix stuff in README
2020-11-13 18:40:03 -05:00
Anmol Sethi
f4d48bc880
ci: Remove helm validation action in favour of helm kubeval directly
2020-11-13 18:38:58 -05:00
Anmol Sethi
9af3671c05
helm: Add link in install.md
2020-11-13 18:38:58 -05:00
Anmol Sethi
248c2adb2e
helm: Fix README examples
...
Not sure where --name came from? Maybe an older version of helm.
Ah, it's from v2.16.7
2020-11-13 18:38:58 -05:00
Anmol Sethi
52ea32f4a7
helm: Move chart into ci/helm-chart
2020-11-13 17:27:52 -05:00
Anmol Sethi
affa64c89c
Merge pull request #2048 from Matthew-Beckett/feature/helm3
...
Update Kubernetes Helm Chart
2020-11-13 16:39:13 -05:00
Asher
5e603056fd
Merge pull request #2238 from cdr/code-asher/ch1385
2020-11-12 14:04:04 -06:00
Asher
9889f30224
Remove unused ts-expect-error from VS Code
...
I'm not sure why other builds are passing with this still in.
2020-11-12 12:30:41 -06:00
Asher
96995b78d1
Update cert flag test
2020-11-12 12:29:41 -06:00
Asher
6f14b8b8dd
Add separate handler for error
...
Feels like it parallels better with the other handlers.
2020-11-12 12:07:45 -06:00
Asher
b73ea2fea2
Unbind message handler itself after getting message
...
Also switch `once` to `on` since we `off` them later anyway so no point
in making Node do it twice.
2020-11-12 12:03:28 -06:00
Asher
e1702a1d21
Merge branch master into code-asher/ch1385
2020-11-12 11:52:02 -06:00
Asher
5499a3d125
Use baseUrl when redirecting from domain proxy
...
This will make the route more robust since it'll work under more than
just the root.
2020-11-12 11:23:52 -06:00
Asher
31b67062b0
Remove <type> from onMessage
...
Turns out that while Typescript can't infer the callback return type
from it, Typescript can do the opposite and infer it from the callback
return type.
2020-11-12 11:17:45 -06:00
Asher
72931edcf0
Fix cleanup after getting message from vscode
2020-11-12 11:16:21 -06:00
Asher
79478eb89f
Clarify some points around the cookie domain
...
Also add a check that the domain has a dot. This covers the localhost
case as well, so remove that.
2020-11-10 18:53:38 -06:00
Asher
4574593664
Refactor vscode init to use async
...
Hopefully is a bit easier to read.
2020-11-10 18:21:20 -06:00
Asher
71850e312b
Avoid setting ?to=/
...
That's the default so it's extra visual noise.
2020-11-10 18:14:18 -06:00
Asher
b8340a2ae9
Close sockets correctly
2020-11-10 17:55:04 -06:00
Asher
f706039a9d
Re-add TLS socket proxy
2020-11-10 17:55:03 -06:00
Asher
de4949571c
Document getFirstPath better
2020-11-10 17:02:39 -06:00
Asher
0a01338edd
Deduplicate child process message dance
2020-11-10 16:36:46 -06:00
Matthew Beckett
aa7415a479
Update CODEOWNERS file
2020-11-10 20:37:14 +00:00
Matthew Beckett
10799aa1ec
Bump chart app version
2020-11-10 20:10:50 +00:00
Matthew Beckett
0e39bb9f2c
Fix trailing line breaks
2020-11-10 20:09:48 +00:00
Matthew Beckett
03aa7709ca
Add maintainers
2020-11-10 20:09:13 +00:00
Matthew Beckett
77c2a72cf8
Bump version and update README
2020-11-10 20:07:38 +00:00
Matthew Beckett
f3d7d3f616
Merge branch 'master' into feature/helm3
2020-11-10 19:08:53 +00:00
Ben Potter
da6000b96f
Add Slack link to issue template ( #2282 )
2020-11-10 14:00:05 -05:00
Anmol Sethi
d969a5bd6b
Merge pull request #2252 from cdr/plugin-5d60
...
Plugin API to add more applications to code-server
2020-11-06 14:49:00 -05:00
Anmol Sethi
fe399ff0fe
Fix formatting
2020-11-06 14:47:08 -05:00
Anmol Sethi
277211c4ce
plugin: Make init and applications callbacks optional
2020-11-06 14:47:08 -05:00
