Archived
1
0

7 Commits

Author SHA1 Message Date
Asher
c416e9b2c4
Use ptyHostService
Most of this was a straightforward replacement of our code with theirs
but I also removed `getDefaultShellAndArgs` since it seems the reference
implementation no longer does that either.

Fixes #2276.
2021-05-07 12:31:24 -05:00
Akash Satheesan
ec8894d6c4 chore(vscode): update to 1.56.0 2021-04-30 20:25:17 +05:30
Akash Satheesan
093743e365
fix(.../platform/terminal): fix compile, add notes 2021-04-14 18:58:17 +05:30
Asher
5ebb096db5
Get terminals working
- Instead of a single listener per terminal that handles all events VS
  Code now has a single listener per event that handles that event for
  all terminals.
- Refactor Terminal to extend TerminalProcess to avoid duplicating
  methods. This required some modifications to TerminalProcess to access
  the pid and title and to set the ID.
- Remove our async change to shutdown. This was necessary to avoid
  disposing too early but shutdown already calls dispose so it turns out
  we didn't need to call it ourselves.
- Rename methods to match the command strings.
- Fix getting system shell (uses process.env).
- Use a single bufferer. Since it already supports buffering for
  multiple terminals there's no need to have one per terminal.
- Remove replay/reconnect logic. It's broken and unused so there doesn't
  seem much point in trying to refactor it to fit the changes right now.

While terminals work now there are still a lot of todos.
2021-04-13 16:35:13 -05:00
Akash Satheesan
8fb96b9967 chore(vscode): update to 1.55.2 2021-04-09 11:32:27 +05:30
Joe Previte
eaf63deb56
fix(lib/vscode): fix return type shutdown in ptyService
In the squash/merge update, we forgot to update the return type.

Add Promise<void> instead of void for shutdown method.
2021-03-16 10:20:12 -07:00
Joe Previte
0cd3e39492
chore(vscode): update to 1.54.2 2021-03-11 10:27:10 -07:00