When `isAuthed()` is called and the password cookie is not what we
expected, the failed login attempt is logged with the provided password,
remote address and user agent.
To allow for logging failed attempts with a reverse proxy, the
`--trust-proxy` argument has been added to trust the `X-Forwarded-For`
header. This implementation of an `X-Forwarded-For` parser uses the last
value in the list, therefore only trusting the nearest proxy.
Since this will be a path in the binary that we don't want to create on
the user's system. I also removed the option to override it; it doesn't
seem like a great idea since you'd always want those builtin extensions.
This way we also don't have to check if the option was passed and only
create it if that was the case.
* Allow setting paths for builtin exts and extra dirs
The extra directories aren't used yet, just available from the
environment service and to the shared process.
* Utilize extra builtin extensions path
* Utilize extra extensions directory
* Fix cached mtimes for extra extension dirs
* Simplify extension cache equality check
* Let people know when telemetry is disabled, change url to https if secure connection
* Remove --no-auth as a http candidate
* Rename variable, change let to const
* Make all assets unique
All CSS and JavaScript files have unique names now. I also moved the
login to the /login path in order to ensure the HTML for each page is
also unique.
* Explicitly include assets to cache
* Update Node to 10.15.1
* Remove string replace that was used for oclif
* Update nbin
* Package node-pty and spdlog with nbin
* Label stderr/stdout from shared process
* Remove fork override
* Prevent "already disposed" errors when trying to kill disposed proxies
* Include spdlog dependencies
* Shim /node_modules
* Add node_modules to Docker ignore
It keeps using my already-built .node files which results in a
mismatching GLIBC version error.
* Update nbin
- "Open folder" now says "open folder" instead of "open file"
- "Open folder" won't allow you to open files
- "Open file" won't allow you to open directories
Fixes#249.
* Update VS Code to 1.33.0
* Fix slow file tree
* Fix WindowsService fill
* Provide `off` on event listeners
* Fix webview
* Fix double title bar and missing preferences on Mac
* Bump VS Code version in Travis config
* Fix black dialog text (again)
* Fix shared process not starting
* Add clear error message if port is in use
* Add bold function for text/numbers
* remove unused dependency:
* remove unused line break
* Change logger message
* Use NodeJS.ErrnoException type
* Add back check for error code
* Convert fully to protobuf (was partially JSON)
* Handle all floating promises
* Remove stringified proto from trace logging
It wasn't proving to be very useful.
Registering returns an instance that lets you retry and recover without
needing to keep passing the name everywhere.
Also refactored the shared process a little to make better use of the
retry and downgraded stderr messages to warnings because they aren't
critical.
* Set low CPU priority on watcher
Fixes#247.
* Batch stat and readdir calls
* Fix fs.exists
callbackify seems to always adds an error as the first argument. Opted
to just use the promise for this one.
* Batch lstat
* Add maximum time for flushing batches
* Replace evaluations with proxies and messages
* Return proxies synchronously
Otherwise events can be lost.
* Ensure events cannot be missed
* Refactor remaining fills
* Use more up-to-date version of util
For callbackify.
* Wait for dispose to come back before removing
This prevents issues with the "done" event not always being the last
event fired. For example a socket might close and then end, but only
if the caller called end.
* Remove old node-pty tests
* Fix emitting events twice on duplex streams
* Preserve environment when spawning processes
* Throw a better error if the proxy doesn't exist
* Remove rimraf dependency from ide
* Update net.Server.listening
* Use exit event instead of killed
Doesn't look like killed is even a thing.
* Add response timeout to server
* Fix trash
* Require node-pty & spdlog after they get unpackaged
This fixes an error when running in the binary.
* Fix errors in down emitter preventing reconnecting
* Fix disposing proxies when nothing listens to "error" event
* Refactor event tests to use jest.fn()
* Reject proxy call when disconnected
Otherwise it'll wait for the timeout which is a waste of time since we
already know the connection is dead.
* Use nbin for binary packaging
* Remove additional module requires
* Attempt to remove require for local bootstrap-fork
* Externalize fsevents
- It logs the error now.
- For some reason when there is an error node-netstat runs the callback
twice. That resulted in us scheduling an exponentially growing number
of calls which ate up all the CPU (and probably memory eventually).
For now, opted to dispose when there is an error.
- Move the old data directory if possible.
- Fix extension path to not use a hard-coded path and instead use the
data directory.
- Create every part of the path during startup.
- Create each path when a connection is made as well in case they are
deleted while the server is running.
- Create every part of the path before saving settings or writing a file
using the resource endpoint.
* Update VS Code to 1.32.0
* Update patch
Most changes are moved files, most notably shell.contribution.ts which
is now main.contribution.ts.
Also:
- repl.ts no longer uses isMacintosh
- shell.ts doesn't exist
- added back the commented-out CSP headers
* Use es6 target for bootstrap-fork
* Directly reference cross-env binary
yarn and npm find the binary just fine when running the tasks from the
root but it doesn't work if you run one of those tasks directly from
within those directories.
* Update import paths and bootstrap-fork ignores
* Increase memory limit for building default extensions
* Fix invalid regex in Firefox
* Update startup function
* Fix global.require error
* Update zip extract arguments
* Update travis to minimum required Node version
* Always chmod executable dependencies
Fixes EACCESS errors for users that had the files unpacked before we
added the chmod call.
* Remove unused var declaration
