From fc3326f1f2ce6cd2f176e941a3615128639f3ce4 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Thu, 20 May 2021 16:26:19 -0700 Subject: [PATCH] feat: add tests using real hashes --- CHANGELOG.md | 6 +----- test/unit/node/util.test.ts | 13 ++++++++++++- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1a995883c..bc4194d83 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,7 +48,7 @@ VS Code v0.00.0 ### Documentation - docs: add Pomerium #3424 @desimone -- docs: fix confusing sentence in pull requests section #3460 @shiv-tyag +- docs: fix confusing sentence in pull requests section #3460 @shiv-tyagi - docs: remove toc from changelog @oxy @jsjoeio - docs(MAINTAINING): add information about CHANGELOG #3467 @jsjoeio - docs: move release process to MAINTAINING.md #3441 @oxy @Prashant168 @@ -82,10 +82,6 @@ VS Code v1.56.1 - fix(ci): update brew-bump.sh to update remote first #3438 @jsjoeio -### Documentation - -- item - ## 3.10.1 VS Code v1.56.1 diff --git a/test/unit/node/util.test.ts b/test/unit/node/util.test.ts index c95994c70..2254a4125 100644 --- a/test/unit/node/util.test.ts +++ b/test/unit/node/util.test.ts @@ -167,6 +167,11 @@ describe("isHashMatch", () => { const _hash = hash(password) expect(isHashMatch("otherPassword123", _hash)).toBe(false) }) + it("should return true with actual hash", () => { + const password = "password" + const _hash = "$2b$10$GA/eZnlboeV9eW8LnntPqe1dZE7tQ/./wCdc7NgJhMRB.xhaJfmG." + expect(isHashMatch(password, _hash)).toBe(true) + }) }) describe("hashLegacy", () => { @@ -177,7 +182,7 @@ describe("hashLegacy", () => { }) }) -describe("isHashLegacyMatchh", () => { +describe("isHashLegacyMatch", () => { it("should return true if is match", () => { const password = "password123" const _hash = hashLegacy(password) @@ -188,4 +193,10 @@ describe("isHashLegacyMatchh", () => { const _hash = hashLegacy(password) expect(isHashLegacyMatch("otherPassword123", _hash)).toBe(false) }) + it("should return true if hashed from command line", () => { + const password = "password123" + // Hashed using printf "password123" | sha256sum | cut -d' ' -f1 + const _hash = "ef92b778bafe771e89245b89ecbc08a44a4e166c06659911881f383d4473e94f" + expect(isHashLegacyMatch(password, _hash)).toBe(true) + }) })