Archived
1
0

refactor: rateLimiter.canTry logic to check >= 1

This commit is contained in:
Joe Previte
2021-04-19 11:21:38 -07:00
parent 7a5042176e
commit f80d5c3764
2 changed files with 5 additions and 2 deletions

View File

@ -18,7 +18,10 @@ export class RateLimiter {
private readonly hourLimiter = new Limiter(12, "hour")
public canTry(): boolean {
return this.minuteLimiter.getTokensRemaining() > 0 || this.hourLimiter.getTokensRemaining() > 0
// Note: we must check using >= 1 because technically when there are no tokens left
// you get back a number like 0.00013333333333333334
// which would cause fail if the logic were > 0
return this.minuteLimiter.getTokensRemaining() >= 1 || this.hourLimiter.getTokensRemaining() >= 1
}
public removeToken(): boolean {