OCram85/code-server
Archived
1
0
Fork 0
Code Pull Requests 2 Activity

Fix accessing manifest behind basic auth

Browse Source 
Apparently the manifest spec doesn't include sending credentials in an
attempt to be secure by default.

Fixes #1212.
This commit is contained in:
Asher 2019-12-09 11:25:59 -06:00
parent 015a99e87d
commit e5fc63f2c8
No known key found for this signature in database
GPG Key ID: D63C1EF81242354A
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/browser/workbench-build.html
View File

@ -37,7 +37,7 @@
<!-- Workbench Icon/Manifest/CSS --> <!-- Workbench Icon/Manifest/CSS -->
<link rel="icon" href="./favicon.ico" type="image/x-icon" /> <link rel="icon" href="./favicon.ico" type="image/x-icon" />
<link rel="manifest" href="./manifest.json"> <link rel="manifest" href="./manifest.json" crossorigin="use-credentials">
<link rel="apple-touch-icon" href="./static-{{COMMIT}}/out/vs/server/src/media/code-server.png" /> <link rel="apple-touch-icon" href="./static-{{COMMIT}}/out/vs/server/src/media/code-server.png" />
<link data-name="vs/workbench/workbench.web.api" rel="stylesheet" href="./static-{{COMMIT}}/out/vs/workbench/workbench.web.api.css"> <link data-name="vs/workbench/workbench.web.api" rel="stylesheet" href="./static-{{COMMIT}}/out/vs/workbench/workbench.web.api.css">
<meta name="apple-mobile-web-app-capable" content="yes"> <meta name="apple-mobile-web-app-capable" content="yes">

2
src/browser/workbench.html
View File

@ -37,7 +37,7 @@
<!-- Workbench Icon/Manifest/CSS --> <!-- Workbench Icon/Manifest/CSS -->
<link rel="icon" href="./favicon.ico" type="image/x-icon" /> <link rel="icon" href="./favicon.ico" type="image/x-icon" />
<link rel="manifest" href="./manifest.json"> <link rel="manifest" href="./manifest.json" crossorigin="use-credentials">
</head> </head>
<body aria-label=""> <body aria-label="">