Archived
1
0

Require minimum node 12

This commit is contained in:
Anmol Sethi 2020-05-14 21:37:58 -04:00
parent 40778b15ca
commit d4b3d21dce
No known key found for this signature in database
GPG Key ID: 8CEF1878FF10ADEB
7 changed files with 21 additions and 4 deletions

View File

@ -41,6 +41,8 @@ platform or architecture.
**note:** Installing via `npm` requires certain dependencies for the native module builds.
See [./doc/npm.md](./doc/npm.md) for installing these dependencies.
You also need at least node v12 installed. See [#1633](https://github.com/cdr/code-server/issues/1633).
```bash
npm install -g code-server
code-server

View File

@ -2,6 +2,16 @@
set -eu
main() {
# Grabs the major version of node from $npm_config_user_agent which looks like
# yarn/1.21.1 npm/? node/v14.2.0 darwin x64
major_node_version=$(echo "$npm_config_user_agent" | sed -n 's/.*node\/v\([^.]*\).*/\1/p')
if [ "$major_node_version" -lt 12 ]; then
echo "code-server currently requires at least node v12"
echo "We have detected that you are on node v$major_node_version"
echo "See https://github.com/cdr/code-server/issues/1633"
exit 1
fi
case "${npm_config_user_agent-}" in npm*)
# We are running under npm.
if [ "${npm_config_unsafe_perm-}" != "true" ]; then

View File

@ -11,7 +11,7 @@ main() {
download_artifact npm-package ./release
# https://github.com/actions/upload-artifact/issues/38
chmod +x $(grep -rl '^#!/.\+' release)
chmod +x $(grep -rl '^#!/.*' release)
yarn publish --non-interactive release
}

View File

@ -5,7 +5,7 @@ main() {
cd "$(dirname "$0")/../.."
# https://github.com/actions/upload-artifact/issues/38
chmod +x $(grep -rl '^#!/.\+' release)
chmod +x $(grep -rl '^#!/.*' release)
yarn release:static
yarn test:static-release

View File

@ -9,7 +9,7 @@ Please refer to [VS Code's prerequisites](https://github.com/Microsoft/vscode/wi
Differences:
- We are not constrained by node version
- We require at least node v12 but later versions should work
- We use [fnpm](https://github.com/goreleaser/nfpm) to build .deb and .rpm packages
## Development Workflow

View File

@ -3,6 +3,8 @@
If you're installing the npm module you'll need certain dependencies to build
the native modules used by VS Code.
You also need at least node v12 installed. See [#1633](https://github.com/cdr/code-server/issues/1633).
## Ubuntu, Debian
```bash

View File

@ -92,5 +92,8 @@
"coder",
"vscode-remote",
"browser-ide"
]
],
"engines": {
"node": ">= 12"
}
}