From 81cf111794f3fece971bf781e86d8f21297e44dd Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Tue, 9 Mar 2021 11:20:14 -0700 Subject: [PATCH 1/2] docs(npm): update node requirements --- docs/npm.md | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/docs/npm.md b/docs/npm.md index e29ff12b3..f0d0b60f4 100644 --- a/docs/npm.md +++ b/docs/npm.md @@ -2,18 +2,24 @@ # npm Install Requirements -- [Ubuntu, Debian](#ubuntu-debian) -- [Fedora, CentOS, RHEL](#fedora-centos-rhel) -- [Alpine](#alpine) -- [macOS](#macos) -- [FreeBSD](#freebsd) +- [npm Install Requirements](#npm-install-requirements) + - [Ubuntu, Debian](#ubuntu-debian) + - [Fedora, CentOS, RHEL](#fedora-centos-rhel) + - [Alpine](#alpine) + - [macOS](#macos) + - [FreeBSD](#freebsd) -If you're installing the npm module you'll need certain dependencies to build -the native modules used by VS Code. +If you're installing the npm module you'll need certain dependencies to build the native modules used by VS Code. -You also need at least node v12 installed. See [#1633](https://github.com/cdr/code-server/issues/1633). +- Node.js: version `>= 12`, `<= 14` + +_Note: the Node.js version requirements are based on the VS Code Node.js requirements. See [here](https://github.com/microsoft/vscode/wiki/How-to-Contribute#prerequisites)._ + +Related: + +- [#1633](https://github.com/cdr/code-server/issues/1633) ## Ubuntu, Debian From 0cb5c2e937ef5a778ba06d92c04ca01486a3a0f7 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Tue, 9 Mar 2021 14:47:23 -0700 Subject: [PATCH 2/2] feat: update node version engine in package.json --- docs/npm.md | 11 +++++------ package.json | 2 +- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/docs/npm.md b/docs/npm.md index f0d0b60f4..aa93be02e 100644 --- a/docs/npm.md +++ b/docs/npm.md @@ -2,12 +2,11 @@ # npm Install Requirements -- [npm Install Requirements](#npm-install-requirements) - - [Ubuntu, Debian](#ubuntu-debian) - - [Fedora, CentOS, RHEL](#fedora-centos-rhel) - - [Alpine](#alpine) - - [macOS](#macos) - - [FreeBSD](#freebsd) +- [Ubuntu, Debian](#ubuntu-debian) +- [Fedora, CentOS, RHEL](#fedora-centos-rhel) +- [Alpine](#alpine) +- [macOS](#macos) +- [FreeBSD](#freebsd) diff --git a/package.json b/package.json index 490583a05..dcfcad5c5 100644 --- a/package.json +++ b/package.json @@ -113,7 +113,7 @@ "browser-ide" ], "engines": { - "node": ">= 12" + "node": ">= 12 <= 14" }, "jest": { "transform": {