OCram85/code-server
Archived
1
0
Fork 0
Code Pull Requests 2 Activity

Fix domains with ports & localhost subdomains

Browse Source
This commit is contained in:
Asher
2020-03-24 14:29:48 -05:00
parent 8aa5675ba2
commit c0dd29c591
2 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/node/app/proxy.ts
View File

@ -61,7 +61,9 @@ export class ProxyHttpProvider extends HttpProvider implements HttpProxyProvider
current = domain
}
})
return current || host
// Setting the domain to localhost doesn't seem to work for subdomains (for
// example dev.localhost).
return current && current !== "localhost" ? current : host
}
public maybeProxyRequest(
@ -90,12 +92,11 @@ export class ProxyHttpProvider extends HttpProvider implements HttpProxyProvider
return undefined
}
// At minimum there needs to be sub.domain.tld.
const host = request.headers.host
const parts = host && host.split(".")
if (!parts || parts.length < 3) {
return undefined
}
// Split into parts.
const host = request.headers.host || ""
const idx = host.indexOf(":")
const domain = idx !== -1 ? host.substring(0, idx) : host
const parts = domain.split(".")
// There must be an exact match.
const port = parts.shift()