From b6e791f7d0341df8c7f843a82f89d6f69cc4f771 Mon Sep 17 00:00:00 2001
From: futengda <fxxjdedd@gmail.com>
Date: Thu, 30 Jul 2020 13:37:41 +0800
Subject: [PATCH] refactor: write route.query via settings.write

I added a shallow parameter, because the query should not be extends, but should be replaced directly.
---
 src/node/app/vscode.ts | 18 +++++++-----------
 src/node/settings.ts   |  8 ++++++--
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/node/app/vscode.ts b/src/node/app/vscode.ts
index e80a2b238..a41212ca6 100644
--- a/src/node/app/vscode.ts
+++ b/src/node/app/vscode.ts
@@ -134,7 +134,6 @@ export class VscodeHttpProvider extends HttpProvider {
           return { redirect: "/login", query: { to: this.options.base } }
         }
         try {
-          this.persistRouteQuery(request, route)
           return await this.getRoot(request, route)
         } catch (error) {
           const message = `<div>VS Code failed to load.</div> ${
@@ -165,13 +164,6 @@ export class VscodeHttpProvider extends HttpProvider {
 
     throw new HttpError("Not found", HttpCode.NotFound)
   }
-  
-  private persistRouteQuery(request: http.IncomingMessage, route: Route): void {
-    const content = Object.keys(route.query).reduce((content, next) => {
-      return (content += `${next}=${route.query[next]}\n`)
-    }, "")
-    fs.writeFile(path.resolve(paths.data, "query"), content)
-  }
 
   private async getRoot(request: http.IncomingMessage, route: Route): Promise<HttpResponse> {
     const remoteAuthority = request.headers.host as string
@@ -191,11 +183,15 @@ export class VscodeHttpProvider extends HttpProvider {
       }),
     ])
 
+    let promise = Promise.resolve()
     if (startPath) {
-      settings.write({
-        lastVisited: startPath,
-      })
+      promise = settings.write({ lastVisited: startPath })
     }
+    // `settings.write` depends on `settings.read` internally. To avoid race conditions, a promise is added here to synchronize.
+    promise.then(() => {
+      // the query should not be extends, but should be replaced directly.
+      settings.write({ query: route.query }, true)
+    })
 
     if (!this.isDev) {
       response.content = response.content.replace(/<!-- PROD_ONLY/g, "").replace(/END_PROD_ONLY -->/g, "")
diff --git a/src/node/settings.ts b/src/node/settings.ts
index 32166ddb7..abb8f63b7 100644
--- a/src/node/settings.ts
+++ b/src/node/settings.ts
@@ -2,6 +2,7 @@ import * as fs from "fs-extra"
 import * as path from "path"
 import { extend, paths } from "./util"
 import { logger } from "@coder/logger"
+import { Route } from "./http"
 
 export type Settings = { [key: string]: Settings | string | boolean | number }
 
@@ -31,9 +32,11 @@ export class SettingsProvider<T> {
    * Write settings combined with current settings. On failure log a warning.
    * Objects will be merged and everything else will be replaced.
    */
-  public async write(settings: Partial<T>): Promise<void> {
+  public async write(settings: Partial<T>, shallow?: boolean): Promise<void> {
     try {
-      await fs.writeFile(this.settingsPath, JSON.stringify(extend(await this.read(), settings), null, 2))
+      const oldSettings = await this.read()
+      const nextSettings = shallow ? Object.assign({}, oldSettings, settings) : extend(oldSettings, settings)
+      await fs.writeFile(this.settingsPath, JSON.stringify(nextSettings, null, 2))
     } catch (error) {
       logger.warn(error.message)
     }
@@ -55,6 +58,7 @@ export interface CoderSettings extends UpdateSettings {
     url: string
     workspace: boolean
   }
+  query: Route["query"]
 }
 
 /**