refactor: remove dead code (#5188)

* refactor: delete unused code

* refactor: move onLine to test helpers

* Revert "refactor: move onLine to test helpers"

This reverts commit 32cc27b213.

* fixup! refactor: delete unused code

test/unit/common/util.test.ts

@@ -24,16 +24,6 @@ describe("util", () => {
     })
   })
 
-  describe("split", () => {
-    it("should split at a comma", () => {
-      expect(util.split("Hello,world", ",")).toStrictEqual(["Hello", "world"])
-    })
-
-    it("shouldn't split if the delimiter doesn't exist", () => {
-      expect(util.split("Hello world", ",")).toStrictEqual(["Hello world", ""])
-    })
-  })
-
   describe("plural", () => {
     it("should add an s if count is greater than 1", () => {
       expect(util.plural(2, "dog")).toBe("dogs")
@@ -57,43 +47,6 @@ describe("util", () => {
     })
   })
 
-  describe("trimSlashes", () => {
-    it("should remove leading slashes", () => {
-      expect(util.trimSlashes("/hello-world")).toBe("hello-world")
-    })
-
-    it("should remove trailing slashes", () => {
-      expect(util.trimSlashes("hello-world/")).toBe("hello-world")
-    })
-
-    it("should remove both leading and trailing slashes", () => {
-      expect(util.trimSlashes("/hello-world/")).toBe("hello-world")
-    })
-
-    it("should remove multiple leading and trailing slashes", () => {
-      expect(util.trimSlashes("///hello-world////")).toBe("hello-world")
-    })
-  })
-
-  describe("arrayify", () => {
-    it("should return value it's already an array", () => {
-      expect(util.arrayify(["hello", "world"])).toStrictEqual(["hello", "world"])
-    })
-
-    it("should wrap the value in an array if not an array", () => {
-      expect(
-        util.arrayify({
-          name: "Coder",
-          version: "3.8",
-        }),
-      ).toStrictEqual([{ name: "Coder", version: "3.8" }])
-    })
-
-    it("should return an empty array if the value is undefined", () => {
-      expect(util.arrayify(undefined)).toStrictEqual([])
-    })
-  })
-
   describe("logError", () => {
     beforeAll(() => {
       mockLogger()

test/unit/node/app.test.ts

@@ -3,7 +3,7 @@ import { promises } from "fs"
 import * as http from "http"
 import * as https from "https"
 import * as path from "path"
-import { createApp, ensureAddress, handleArgsSocketCatchError, handleServerError, listen } from "../../../src/node/app"
+import { createApp, ensureAddress, handleArgsSocketCatchError, listen } from "../../../src/node/app"
 import { OptionalString, setDefaults } from "../../../src/node/cli"
 import { generateCertificate } from "../../../src/node/util"
 import { clean, mockLogger, getAvailablePort, tmpdir } from "../../utils/helpers"
@@ -169,38 +169,6 @@ describe("ensureAddress", () => {
   })
 })
 
-describe("handleServerError", () => {
-  beforeAll(() => {
-    mockLogger()
-  })
-
-  afterEach(() => {
-    jest.clearAllMocks()
-  })
-
-  it("should call reject if resolved is false", async () => {
-    const resolved = false
-    const reject = jest.fn((err: Error) => undefined)
-    const error = new Error("handleServerError Error")
-
-    handleServerError(resolved, error, reject)
-
-    expect(reject).toHaveBeenCalledTimes(1)
-    expect(reject).toHaveBeenCalledWith(error)
-  })
-
-  it("should log an error if resolved is true", async () => {
-    const resolved = true
-    const reject = jest.fn((err: Error) => undefined)
-    const error = new Error("handleServerError Error")
-
-    handleServerError(resolved, error, reject)
-
-    expect(logger.error).toHaveBeenCalledTimes(1)
-    expect(logger.error).toHaveBeenCalledWith(`http server error: ${error.message} ${error.stack}`)
-  })
-})
-
 describe("handleArgsSocketCatchError", () => {
   beforeAll(() => {
     mockLogger()

test/unit/node/constants.test.ts

@@ -34,10 +34,6 @@ describe("constants", () => {
       jest.resetModules()
     })
 
-    it("should provide the package name", () => {
-      expect(constants.pkgName).toBe(mockPackageJson.name)
-    })
-
     it("should provide the commit", () => {
       expect(constants.commit).toBe(mockPackageJson.commit)
     })