Archived
1
0

refactor: change limiter.Try() to .removeToken()

This commit is contained in:
Joe Previte
2021-04-19 10:57:50 -07:00
parent 7928dc2bff
commit a3f18d6158
2 changed files with 10 additions and 12 deletions

View File

@ -4,20 +4,20 @@ describe("login", () => {
describe("RateLimiter", () => {
it("should allow one try ", () => {
const limiter = new RateLimiter()
expect(limiter.try()).toBe(true)
expect(limiter.removeToken()).toBe(true)
})
it("should pull tokens from both limiters (minute & hour)", () => {
const limiter = new RateLimiter()
// Try twice, which pulls two from the minute bucket
limiter.try()
limiter.try()
limiter.removeToken()
limiter.removeToken()
// Check that we can still try
// which should be true since there are 12 remaining in the hour bucket
expect(limiter.canTry()).toBe(true)
expect(limiter.try()).toBe(true)
expect(limiter.removeToken()).toBe(true)
})
it("should not allow more than 14 tries in less than an hour", () => {
@ -27,10 +27,11 @@ describe("login", () => {
// so if we run it 15 times, 14 should return true and the last
// should return false
for (let i = 1; i <= 14; i++) {
expect(limiter.try()).toBe(true)
expect(limiter.removeToken()).toBe(true)
}
expect(limiter.try()).toBe(false)
expect(limiter.canTry()).toBe(false)
expect(limiter.removeToken()).toBe(false)
})
})
})