OCram85/code-server
Archived
1
0
Fork 0
Code Pull Requests 2 Activity

refactor: change limiter.Try() to .removeToken()

Browse Source
This commit is contained in:
Joe Previte
2021-04-19 10:57:50 -07:00
parent 7928dc2bff
commit a3f18d6158
2 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/node/routes/login.ts
View File

@ -21,11 +21,8 @@ export class RateLimiter {
return this.minuteLimiter.getTokensRemaining() > 0 || this.hourLimiter.getTokensRemaining() > 0
}
public try(): boolean {
if (this.canTry()) {
return this.minuteLimiter.tryRemoveTokens(1) || this.hourLimiter.tryRemoveTokens(1)
}
return false
public removeToken(): boolean {
return this.minuteLimiter.tryRemoveTokens(1) || this.hourLimiter.tryRemoveTokens(1)
}
}
@ -91,7 +88,7 @@ router.post("/", async (req, res) => {
// Note: successful logins should not count against the RateLimiter
// which is why this logic must come after the successful login logic
if (!limiter.try()) {
if (!limiter.removeToken()) {
throw new Error("Login rate limited!")
}