refactor: delete buggy socket test
This test was really added to in get cover specific lines but it's buggy and only passes sometimes locally. I think it's okay to remove because: - it's an implementation detail (not user facing) - not preventing any specific regressions
This commit is contained in:
parent
74330a1e05
commit
a0944006e7
@ -107,20 +107,6 @@ describe("createApp", () => {
|
|||||||
app.dispose()
|
app.dispose()
|
||||||
})
|
})
|
||||||
|
|
||||||
// TODO@jsjoeio - delete because this test it buggy?
|
|
||||||
// or move into it's own describe block
|
|
||||||
it("should change the file mode of a socket", async () => {
|
|
||||||
const defaultArgs = await setDefaults({
|
|
||||||
socket: tmpFilePath,
|
|
||||||
"socket-mode": "777",
|
|
||||||
})
|
|
||||||
|
|
||||||
const app = await createApp(defaultArgs)
|
|
||||||
|
|
||||||
expect((await promises.stat(tmpFilePath)).mode & 0o777).toBe(0o777)
|
|
||||||
app.dispose()
|
|
||||||
})
|
|
||||||
|
|
||||||
it("should create an https server if args.cert exists", async () => {
|
it("should create an https server if args.cert exists", async () => {
|
||||||
const testCertificate = await generateCertificate("localhost")
|
const testCertificate = await generateCertificate("localhost")
|
||||||
const cert = new OptionalString(testCertificate.cert)
|
const cert = new OptionalString(testCertificate.cert)
|
||||||
|
Reference in New Issue
Block a user