Archived
1
0

refactor: remove null check in register.ts options.base

Inside registerServiceWorker, we were originally using the nullash coalescing
operator to check if options.base was null or undefined. However, I realized
this check is not necessary.

If you look at getOptions' return value, we return an object with a key "base"
which is of type "string". We get that value by calling resolveBase which always
returns a string.

As a result, we didn't need to check if options.base was null or undefined
because it never can be.
This commit is contained in:
Joe Previte
2021-04-23 16:32:12 -07:00
parent 6f2709bcaa
commit 83746c8a1f
2 changed files with 2 additions and 3 deletions

View File

@ -105,7 +105,6 @@ describe("register", () => {
const location: LocationLike = {
pathname: "",
origin: "http://localhost:8080",
// search: "?environmentId=600e0187-0909d8a00cb0a394720d4dce",
}
const { window } = new JSDOM()
global.window = (window as unknown) as Window & typeof globalThis