OCram85/code-server
Archived
1
0
Fork 0
Code Pull Requests 2 Activity

$PORT should always override port in --bind-addr

Browse Source
This commit is contained in:
Anmol Sethi
2020-05-14 21:57:10 -04:00
parent 89c5a4dfea
commit 73b2ff0945
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/node/cli.ts
View File

@ -380,6 +380,10 @@ function bindAddrFromArgs(addr: Addr, args: Args): Addr {
if (args.host) {
addr.host = args.host
}
if (process.env.PORT) {
addr.port = parseInt(process.env.PORT, 10)
}
if (args.port !== undefined) {
addr.port = args.port
}
@ -393,11 +397,6 @@ export function bindAddrFromAllSources(cliArgs: Args, configArgs: Args): [string
}
addr = bindAddrFromArgs(addr, configArgs)
if (process.env.PORT) {
addr.port = parseInt(process.env.PORT, 10)
}
addr = bindAddrFromArgs(addr, cliArgs)
return [addr.host, addr.port]