From a72e8a698d1c65877f4515cc8648c29ec6de7046 Mon Sep 17 00:00:00 2001 From: Frank Petrilli Date: Mon, 1 Jul 2019 14:05:35 -0700 Subject: [PATCH 1/2] Add `use-credentials` to fetch manifest with cookies I run code-server behind an authenticating Kubernetes Ingress which sets a cookie after a successful login is performed. Since this cookie is not set when fetching the manifest, the fetch fails and gets redirected to the authentication page, breaking code-server completely. See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link --- scripts/webpack.client.config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/webpack.client.config.js b/scripts/webpack.client.config.js index 31ab2a7e0..793130fed 100644 --- a/scripts/webpack.client.config.js +++ b/scripts/webpack.client.config.js @@ -61,6 +61,7 @@ module.exports = (options = {}) => merge( short_name: "Coder", description: "Run VS Code on a remote server", background_color: "#e5e5e5", + crossorigin: 'use-credentials', icons: [{ src: path.join(root, "packages/web/assets/logo.png"), sizes: [96, 128, 192, 256, 384], From 11784e55b2971461bf7348b8481670e2ddac8069 Mon Sep 17 00:00:00 2001 From: Frank Petrilli Date: Mon, 1 Jul 2019 14:10:32 -0700 Subject: [PATCH 2/2] Change quote style to match existing work --- scripts/webpack.client.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/webpack.client.config.js b/scripts/webpack.client.config.js index 793130fed..cb4b41f7e 100644 --- a/scripts/webpack.client.config.js +++ b/scripts/webpack.client.config.js @@ -61,7 +61,7 @@ module.exports = (options = {}) => merge( short_name: "Coder", description: "Run VS Code on a remote server", background_color: "#e5e5e5", - crossorigin: 'use-credentials', + crossorigin: "use-credentials", icons: [{ src: path.join(root, "packages/web/assets/logo.png"), sizes: [96, 128, 192, 256, 384],