Archived
1
0

Merge pull request #3728 from cdr/jsjoeio-fix-open-folder-explorer-panel

fix: openFolder button on Explorer panel
This commit is contained in:
Joe Previte 2021-07-06 15:02:29 -07:00 committed by GitHub
commit 6f7ae29dc4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -303,9 +303,15 @@ viewsRegistry.registerViewWelcomeContent(EmptyView.ID, {
order: 1 order: 1
}); });
// NOTE@coder:
// We use OpenFolderAction.ID instead of commandId
// because for some reason, the command openFileFolder
// does not work as expected and causes the "Open Folder"
// command to not work
// See: https://github.com/cdr/code-server/issues/3457
viewsRegistry.registerViewWelcomeContent(EmptyView.ID, { viewsRegistry.registerViewWelcomeContent(EmptyView.ID, {
content: localize({ key: 'noFolderHelp', comment: ['Please do not translate the word "commmand", it is part of our internal syntax which must not change'] }, content: localize({ key: 'noFolderHelp', comment: ['Please do not translate the word "commmand", it is part of our internal syntax which must not change'] },
"You have not yet opened a folder.\n[Open Folder](command:{0})", commandId), "You have not yet opened a folder.\n[Open Folder](command:{0})", OpenFolderAction.ID),
when: ContextKeyExpr.or(ContextKeyExpr.and(WorkbenchStateContext.notEqualsTo('workspace'), RemoteNameContext.isEqualTo('')), ContextKeyExpr.and(WorkbenchStateContext.notEqualsTo('workspace'), IsWebContext)), when: ContextKeyExpr.or(ContextKeyExpr.and(WorkbenchStateContext.notEqualsTo('workspace'), RemoteNameContext.isEqualTo('')), ContextKeyExpr.and(WorkbenchStateContext.notEqualsTo('workspace'), IsWebContext)),
group: ViewContentGroups.Open, group: ViewContentGroups.Open,
order: 1 order: 1