From 6e1455da88966b86adcf8423bc10b2880c5e2c8b Mon Sep 17 00:00:00 2001
From: Joe Previte <jjprevite@gmail.com>
Date: Wed, 23 Jun 2021 10:49:22 -0700
Subject: [PATCH] feat: add custom codecov

---
 .github/codecov.yml              | 21 +++++++++++++++++
 test/browser/pages/login.test.ts | 40 +++++++-------------------------
 2 files changed, 29 insertions(+), 32 deletions(-)
 create mode 100644 .github/codecov.yml

diff --git a/.github/codecov.yml b/.github/codecov.yml
new file mode 100644
index 000000000..0bc72f2ca
--- /dev/null
+++ b/.github/codecov.yml
@@ -0,0 +1,21 @@
+codecov:
+  require_ci_to_pass: yes
+  allow_coverage_offsets: True
+
+coverage:
+  precision: 2
+  round: down
+  range: "70...100"
+
+parsers:
+  gcov:
+    branch_detection:
+      conditional: yes
+      loop: yes
+      method: no
+      macro: no
+
+comment:
+  layout: "reach,diff,flags,files,footer"
+  behavior: default
+  require_changes: no
diff --git a/test/browser/pages/login.test.ts b/test/browser/pages/login.test.ts
index 7f77d9665..0bd500ebb 100644
--- a/test/browser/pages/login.test.ts
+++ b/test/browser/pages/login.test.ts
@@ -25,10 +25,14 @@ describe("login", () => {
       // Create a fake element and set the attribute
       const mockElement = document.createElement("input")
       mockElement.setAttribute("id", "base")
-      mockElement.setAttribute(
-        "data-settings",
-        '{"base":"./hello-world","csStaticBase":"./static/development/Users/jp/Dev/code-server","logLevel":2,"disableTelemetry":false,"disableUpdateCheck":false}',
-      )
+      const expected = {
+        base: "./hello-world",
+        csStaticBase: "./static/development/Users/jp/Dev/code-server",
+        logLevel: 2,
+        disableTelemetry: false,
+        disableUpdateCheck: false,
+      }
+      mockElement.setAttribute("data-settings", JSON.stringify(expected))
       document.body.appendChild(mockElement)
       spy.mockImplementation(() => mockElement)
       // Load file
@@ -38,32 +42,4 @@ describe("login", () => {
       expect(el?.value).toBe("/hello-world")
     })
   })
-
-  describe("there is no element with id 'base'", () => {
-    let initialDom: Document
-    beforeEach(() => {
-      const dom = new JSDOM()
-      initialDom = dom.window.document
-      global.document = dom.window.document
-
-      const location: LocationLike = {
-        pathname: "/healthz",
-        origin: "http://localhost:8080",
-      }
-
-      global.location = location as Location
-    })
-    afterEach(() => {
-      // Reset the global.document
-      global.document = undefined as any as Document
-      global.location = undefined as any as Location
-    })
-
-    it("should not change the DOM", () => {
-      // Load file
-      require("../../../src/browser/pages/login")
-      const currentDom = global.document
-      expect(initialDom).toBe(currentDom)
-    })
-  })
 })