OCram85/code-server
Archived
1
0
Fork 0
Code Pull Requests 2 Activity

Make websocket upgrade check case-insensitive

Browse Source 
Fixes #925.
This commit is contained in:
Asher 2019-09-16 14:18:58 -05:00
parent 5c16399810
commit 6a864f9f47
No known key found for this signature in database
GPG Key ID: D63C1EF81242354A
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/quickstart.md
View File

@ -46,13 +46,8 @@ server {
RewriteRule /(.*) http://localhost:8080/$1 [P,L] RewriteRule /(.*) http://localhost:8080/$1 [P,L]
ProxyRequests off ProxyRequests off
ProxyPass / http://localhost:8080/ nocanon
RequestHeader set X-Forwarded-Proto https
RequestHeader set X-Forwarded-Port 443
ProxyPass / http://localhost:8080/ nocanon
ProxyPassReverse / http://localhost:8080/ ProxyPassReverse / http://localhost:8080/
</VirtualHost> </VirtualHost>
``` ```

2
src/server.ts
View File

@ -331,7 +331,7 @@ export abstract class Server {
this.ensureGet(request); this.ensureGet(request);
if (!this.authenticate(request)) { if (!this.authenticate(request)) {
throw new HttpError("Unauthorized", HttpCode.Unauthorized); throw new HttpError("Unauthorized", HttpCode.Unauthorized);
} else if (request.headers.upgrade !== "websocket") { } else if (!request.headers.upgrade || request.headers.upgrade.toLowerCase() !== "websocket") {
throw new Error("HTTP/1.1 400 Bad Request"); throw new Error("HTTP/1.1 400 Bad Request");
} }