Archived
1
0

chore: update node to v14 (#3481)

This commit is contained in:
Akash Satheesan
2021-06-01 22:49:03 +05:30
committed by GitHub
parent c2a8634bcc
commit 58622ccc34
8 changed files with 49 additions and 30 deletions

View File

@ -35,7 +35,7 @@ The prerequisites for contributing to code-server are almost the same as those f
[VS Code](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites).
There are several differences, however. Here is what is needed:
- `node` v12.x or greater
- `node` v14.x or greater
- `git` v2.x or greater
- [`yarn`](https://classic.yarnpkg.com/en/)
- used to install JS packages and run scripts
@ -74,6 +74,7 @@ To update VS Code, follow these steps:
4. There will be merge conflicts. First commit them.
1. We do this because if we don't, it will be impossible to review your PR.
5. Once they're all fixed, test code-server locally and make sure it all works.
6. Check the version of Node.js that the version of Electron shipped with VSCode uses, and update the version of Node.js if necessary.
#### Notes about Changes

View File

@ -12,9 +12,9 @@
If you're installing the npm module you'll need certain dependencies to build the native modules used by VS Code.
- Node.js: version `>= 12`, `<= 14`
- Node.js: version `= 14`. Other versions may work, but your mileage may vary.
_Note: the Node.js version requirements are based on the VS Code Node.js requirements. See [here](https://github.com/microsoft/vscode/wiki/How-to-Contribute#prerequisites)._
_Note: We use the same major version of Node.js that is shipped in VSCode's Electron. VS Code also lists Node.js requirements. See [here](https://github.com/microsoft/vscode/wiki/How-to-Contribute#prerequisites)._
Related:
@ -55,6 +55,6 @@ xcode-select --install
## FreeBSD
```sh
pkg install -y git python npm-node12 yarn-node12 pkgconf
pkg install -y git python npm-node14 yarn-node14 pkgconf
pkg install -y libinotify
```