diff --git a/packages/server/src/cli.ts b/packages/server/src/cli.ts index 1622461b4..bca6ee22a 100644 --- a/packages/server/src/cli.ts +++ b/packages/server/src/cli.ts @@ -117,11 +117,9 @@ export class Entry extends Command { app.wss.on("connection", (ws, req) => { const id = clientId++; - ws.on("open", () => { - if (sharedProcess.state === SharedProcessState.Ready) { - sendSharedProcessReady(ws); - } - }); + if (sharedProcess.state === SharedProcessState.Ready) { + sendSharedProcessReady(ws); + } logger.info(`WebSocket opened \u001B[0m${req.url}`, field("client", id), field("ip", req.socket.remoteAddress)); diff --git a/packages/server/src/server.ts b/packages/server/src/server.ts index efae772b8..4116ebc12 100644 --- a/packages/server/src/server.ts +++ b/packages/server/src/server.ts @@ -1,3 +1,4 @@ +import { field, logger } from "@coder/logger"; import { ReadWriteConnection } from "@coder/protocol"; import { Server, ServerOptions } from "@coder/protocol/src/node/server"; import { NewSessionMessage } from '@coder/protocol/src/proto'; @@ -24,13 +25,19 @@ export const createApp = (registerMiddleware?: (app: express.Application) => voi return true; }; - wss.on("connection", (ws: WebSocket, req) => { + wss.on("connection", (ws) => { const connection: ReadWriteConnection = { onMessage: (cb): void => { ws.addEventListener("message", (event) => cb(event.data)); }, close: (): void => ws.close(), - send: (data): void => ws.send(data), + send: (data): void => { + try { + ws.send(data); + } catch (error) { + logger.error(error.message, field("error", error)); + } + }, onClose: (cb): void => ws.addEventListener("close", () => cb()), };