Handle permessage-deflate on sockets
With this the extension host is working again.
This commit is contained in:
@ -68,7 +68,7 @@ process.on('message', async (message: CodeServerMessage, socket) => {
|
||||
}
|
||||
break;
|
||||
case 'socket':
|
||||
vscode.handleWebSocket(socket, message.query);
|
||||
vscode.handleWebSocket(socket, message.query, message.permessageDeflate);
|
||||
break;
|
||||
}
|
||||
});
|
||||
|
1
lib/vscode/src/vs/server/ipc.d.ts
vendored
1
lib/vscode/src/vs/server/ipc.d.ts
vendored
@ -19,6 +19,7 @@ export type Query = { [key: string]: string | string[] | undefined | Query | Que
|
||||
export interface SocketMessage {
|
||||
type: 'socket';
|
||||
query: Query;
|
||||
permessageDeflate: boolean;
|
||||
}
|
||||
|
||||
export interface CliMessage {
|
||||
|
@ -4,7 +4,7 @@ import { VSBuffer } from 'vs/base/common/buffer';
|
||||
import { Emitter } from 'vs/base/common/event';
|
||||
import { FileAccess } from 'vs/base/common/network';
|
||||
import { ISocket } from 'vs/base/parts/ipc/common/ipc.net';
|
||||
import { NodeSocket } from 'vs/base/parts/ipc/node/ipc.net';
|
||||
import { WebSocketNodeSocket } from 'vs/base/parts/ipc/node/ipc.net';
|
||||
import { INativeEnvironmentService } from 'vs/platform/environment/common/environment';
|
||||
import { getNlsConfiguration } from 'vs/server/node/nls';
|
||||
import { Protocol } from 'vs/server/node/protocol';
|
||||
@ -88,7 +88,7 @@ export class ExtensionHostConnection extends Connection {
|
||||
private readonly logger: Logger;
|
||||
|
||||
public constructor(
|
||||
locale:string, protocol: Protocol, buffer: VSBuffer, token: string,
|
||||
locale: string, protocol: Protocol, buffer: VSBuffer, token: string,
|
||||
private readonly environment: INativeEnvironmentService,
|
||||
) {
|
||||
super(protocol, token);
|
||||
@ -115,11 +115,18 @@ export class ExtensionHostConnection extends Connection {
|
||||
private sendInitMessage(buffer: VSBuffer): void {
|
||||
const socket = this.protocol.getUnderlyingSocket();
|
||||
socket.pause();
|
||||
|
||||
const wrapperSocket = this.protocol.getSocket();
|
||||
|
||||
this.logger.trace('Sending socket');
|
||||
this.process!.send({ // Process must be set at this point.
|
||||
type: 'VSCODE_EXTHOST_IPC_SOCKET',
|
||||
initialDataChunk: (buffer.buffer as Buffer).toString('base64'),
|
||||
skipWebSocketFrames: this.protocol.getSocket() instanceof NodeSocket,
|
||||
initialDataChunk: Buffer.from(buffer.buffer).toString('base64'),
|
||||
skipWebSocketFrames: !(wrapperSocket instanceof WebSocketNodeSocket),
|
||||
permessageDeflate: this.protocol.options.permessageDeflate,
|
||||
inflateBytes: wrapperSocket instanceof WebSocketNodeSocket
|
||||
? Buffer.from(wrapperSocket.recordedInflateBytes.buffer).toString('base64')
|
||||
: undefined,
|
||||
}, socket);
|
||||
}
|
||||
|
||||
|
@ -10,6 +10,9 @@ export interface SocketOptions {
|
||||
readonly reconnectionToken: string;
|
||||
readonly reconnection: boolean;
|
||||
readonly skipWebSocketFrames: boolean;
|
||||
readonly permessageDeflate?: boolean;
|
||||
readonly inflateBytes?: VSBuffer;
|
||||
readonly recordInflateBytes?: boolean;
|
||||
}
|
||||
|
||||
export class Protocol extends PersistentProtocol {
|
||||
@ -17,7 +20,12 @@ export class Protocol extends PersistentProtocol {
|
||||
super(
|
||||
options.skipWebSocketFrames
|
||||
? new NodeSocket(socket)
|
||||
: new WebSocketNodeSocket(new NodeSocket(socket), false, null, false),
|
||||
: new WebSocketNodeSocket(
|
||||
new NodeSocket(socket),
|
||||
options.permessageDeflate || false,
|
||||
options.inflateBytes || null,
|
||||
options.recordInflateBytes || false,
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
|
@ -120,7 +120,7 @@ export class Vscode {
|
||||
};
|
||||
}
|
||||
|
||||
public async handleWebSocket(socket: net.Socket, query: Query): Promise<true> {
|
||||
public async handleWebSocket(socket: net.Socket, query: Query, _permessageDeflate: boolean): Promise<true> {
|
||||
if (!query.reconnectionToken) {
|
||||
throw new Error('Reconnection token is missing from query parameters');
|
||||
}
|
||||
@ -128,6 +128,7 @@ export class Vscode {
|
||||
reconnectionToken: <string>query.reconnectionToken,
|
||||
reconnection: query.reconnection === 'true',
|
||||
skipWebSocketFrames: query.skipWebSocketFrames === 'true',
|
||||
// TODO: permessageDeflate,
|
||||
});
|
||||
try {
|
||||
await this.connect(await protocol.handshake(), protocol);
|
||||
|
Reference in New Issue
Block a user