OCram85/code-server
Archived
1
0
Fork 0
Code Pull Requests 2 Activity

Make sure heartbeat isActive resolves

Browse Source 
This does not seem to actually cause an issue (not resolving ends up
with the same behavior as resolving with false) but I am not sure if the
hanging promises would be a memory leak so seems best to fix.
This commit is contained in:
Asher 2023-02-08 11:41:23 -09:00
parent 6d6c5e18d1
commit 45aef719d3
No known key found for this signature in database
GPG Key ID: D63C1EF81242354A
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/node/routes/index.ts
View File

@ -33,7 +33,15 @@ import { CodeServerRouteWrapper } from "./vscode"
export const register = async (app: App, args: DefaultedArgs): Promise<Disposable["dispose"]> => { export const register = async (app: App, args: DefaultedArgs): Promise<Disposable["dispose"]> => {
const heart = new Heart(path.join(paths.data, "heartbeat"), async () => { const heart = new Heart(path.join(paths.data, "heartbeat"), async () => {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
// getConnections appears to not call the callback when there are no more
// connections. Feels like it must be a bug? For now add a timer to make
// sure we eventually resolve.
const timer = setTimeout(() => {
logger.debug("Node failed to respond with connections; assuming zero")
resolve(false)
}, 5000)
app.server.getConnections((error, count) => { app.server.getConnections((error, count) => {
clearTimeout(timer)
if (error) { if (error) {
return reject(error) return reject(error)
} }