From 3ad618db97408e8c076e7a9562c5107e95e187bd Mon Sep 17 00:00:00 2001 From: Thomas John Wesolowski Date: Mon, 14 Feb 2022 16:34:07 -0600 Subject: [PATCH] feat: Add support for imagePullSecrets to Helm chart (#4838) * add support for imagePullSecrets * Add doc and example value for imagePullSecrets * simplify syntax for imagePullSecrets Co-authored-by: Joe Previte --- ci/helm-chart/templates/deployment.yaml | 1 + ci/helm-chart/values.yaml | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/ci/helm-chart/templates/deployment.yaml b/ci/helm-chart/templates/deployment.yaml index 3f0d11d5c..f137a9d2a 100644 --- a/ci/helm-chart/templates/deployment.yaml +++ b/ci/helm-chart/templates/deployment.yaml @@ -21,6 +21,7 @@ spec: app.kubernetes.io/name: {{ include "code-server.name" . }} app.kubernetes.io/instance: {{ .Release.Name }} spec: + imagePullSecrets: {{- toYaml .Values.imagePullSecrets | nindent 8 }} {{- if .Values.hostnameOverride }} hostname: {{ .Values.hostnameOverride }} {{- end }} diff --git a/ci/helm-chart/values.yaml b/ci/helm-chart/values.yaml index 19c6a5eae..f37771999 100644 --- a/ci/helm-chart/values.yaml +++ b/ci/helm-chart/values.yaml @@ -9,7 +9,12 @@ image: tag: '4.0.2' pullPolicy: Always +# Specifies one or more secrets to be used when pulling images from a +# private container repository +# https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry imagePullSecrets: [] +# - name: registry-creds + nameOverride: "" fullnameOverride: "" hostnameOverride: ""