fix: add node to path (#5598)
* fix: remove deprecated symlink * refactor: remove deprecation notice * fixup! refactor: remove deprecation notice * fix: add node to path * fixup: shellcheck * Update src/node/wrapper.ts Co-authored-by: Asher <ash@coder.com> * fixup!: fix: remove deprecated symlink * Update ci/build/build-vscode.sh Co-authored-by: Asher <ash@coder.com> * Update ci/build/build-vscode.sh Co-authored-by: Asher <ash@coder.com> * fixup: use NODE_EXEC_PATh * Update ci/build/build-vscode.sh Co-authored-by: Asher <ash@coder.com> Co-authored-by: Asher <ash@coder.com>
This commit is contained in:
12
.github/workflows/build.yaml
vendored
12
.github/workflows/build.yaml
vendored
@ -318,12 +318,6 @@ jobs:
|
||||
./test/node_modules/.bin/playwright install-deps
|
||||
./test/node_modules/.bin/playwright install
|
||||
|
||||
# TODO@jsjoeio - this is temp. We need to do an actual fix
|
||||
- name: Copy node binary to release
|
||||
run: |
|
||||
ln -s $(which node) ./release/lib/node
|
||||
ln -s $(which node) ./release/node
|
||||
|
||||
- name: Run end-to-end tests
|
||||
run: CODE_SERVER_TEST_ENTRY=./release yarn test:e2e --global-timeout 840000
|
||||
|
||||
@ -400,12 +394,6 @@ jobs:
|
||||
- name: Start Caddy
|
||||
run: sudo ~/.cache/caddy/caddy start --config ./ci/Caddyfile
|
||||
|
||||
# TODO@jsjoeio - this is temp. We need to do an actual fix
|
||||
- name: Copy node binary to release
|
||||
run: |
|
||||
ln -s $(which node) ./release/lib/node
|
||||
ln -s $(which node) ./release/node
|
||||
|
||||
- name: Run end-to-end tests
|
||||
run: CODE_SERVER_TEST_ENTRY=./release yarn test:e2e:proxy --global-timeout 840000
|
||||
|
||||
|
Reference in New Issue
Block a user