From 31bc0c6b1a19fcfd3d2e7ac7e44601d65c3d0679 Mon Sep 17 00:00:00 2001 From: Asher Date: Thu, 25 Jul 2024 09:16:15 -0800 Subject: [PATCH] Fix dangling links in standalone release The fix will now run both to the GitHub and npm release instead of only for the npm releases. Closes #5157. --- ci/build/build-packages.sh | 5 ----- ci/build/build-standalone-release.sh | 4 ++++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/ci/build/build-packages.sh b/ci/build/build-packages.sh index 1844dc741..d9840d1c3 100755 --- a/ci/build/build-packages.sh +++ b/ci/build/build-packages.sh @@ -50,11 +50,6 @@ release_nfpm() { export NFPM_ARCH - # Code deletes some files from the extension node_modules directory which - # leaves broken symlinks in the corresponding .bin directory. nfpm will fail - # on these broken symlinks so clean them up. - rm -fr "./release-standalone/lib/vscode/extensions/node_modules/.bin" - PKG_FORMAT="deb" NFPM_ARCH="$(get_nfpm_arch $PKG_FORMAT "$ARCH")" nfpm_config="$(envsubst < ./ci/build/nfpm.yaml)" diff --git a/ci/build/build-standalone-release.sh b/ci/build/build-standalone-release.sh index aed25ee3f..78e665de7 100755 --- a/ci/build/build-standalone-release.sh +++ b/ci/build/build-standalone-release.sh @@ -24,6 +24,10 @@ main() { pushd "$RELEASE_PATH" npm install --unsafe-perm --omit=dev + # Code deletes some files from the extension node_modules directory which + # leaves broken symlinks in the corresponding .bin directory. nfpm will fail + # on these broken symlinks so clean them up. + rm -fr "./lib/vscode/extensions/node_modules/.bin" popd }