Archived
1
0

Remove unnecessary return types

This commit is contained in:
Asher
2020-03-11 16:00:39 -05:00
parent f6a5eaa965
commit 253cf1c438
3 changed files with 7 additions and 19 deletions

View File

@ -93,7 +93,7 @@ export class ApiHttpProvider extends HttpProvider {
request: http.IncomingMessage,
socket: net.Socket,
head: Buffer,
): Promise<true> {
): Promise<void> {
if (!this.authenticated(request)) {
throw new Error("not authenticated")
}
@ -107,7 +107,7 @@ export class ApiHttpProvider extends HttpProvider {
throw new HttpError("Not found", HttpCode.NotFound)
}
private async handleStatusSocket(request: http.IncomingMessage, socket: net.Socket, head: Buffer): Promise<true> {
private async handleStatusSocket(request: http.IncomingMessage, socket: net.Socket, head: Buffer): Promise<void> {
const getMessageResponse = async (event: "health"): Promise<ServerMessage> => {
switch (event) {
case "health":
@ -134,8 +134,6 @@ export class ApiHttpProvider extends HttpProvider {
resolve()
})
})
return true
}
/**
@ -146,7 +144,7 @@ export class ApiHttpProvider extends HttpProvider {
request: http.IncomingMessage,
socket: net.Socket,
head: Buffer,
): Promise<true> {
): Promise<void> {
const sessionId = route.requestPath.replace(/^\//, "")
logger.debug("connecting session", field("sessionId", sessionId))
const ws = await new Promise<WebSocket>((resolve, reject) => {
@ -177,8 +175,6 @@ export class ApiHttpProvider extends HttpProvider {
}),
),
)
return true
}
/**

View File

@ -89,7 +89,7 @@ export class VscodeHttpProvider extends HttpProvider {
return this._vscode
}
public async handleWebSocket(route: Route, request: http.IncomingMessage, socket: net.Socket): Promise<true> {
public async handleWebSocket(route: Route, request: http.IncomingMessage, socket: net.Socket): Promise<void> {
if (!this.authenticated(request)) {
throw new Error("not authenticated")
}
@ -113,7 +113,6 @@ export class VscodeHttpProvider extends HttpProvider {
const vscode = await this._vscode
this.send({ type: "socket", query: route.query }, vscode, socket)
return true
}
private send(message: CodeServerMessage, vscode?: cp.ChildProcess, socket?: net.Socket): void {