From 2530a0d265c4c494e65fe158d12607dc5467a98c Mon Sep 17 00:00:00 2001
From: Joe Previte <jjprevite@gmail.com>
Date: Wed, 2 Nov 2022 14:34:38 -0700
Subject: [PATCH] release: 4.8.2 (#5743)

* chore: bump version to 4.8.2

* chore: update CHANGELOG

* docs: add back line in publishing release

See https://github.com/coder/code-server/pull/5732#discussion_r1010685933

* Revert "chore: bump version to 4.8.2"

This reverts commit 5d70994f22e461602a64f39771b27c78d6c38dcf.

* fixup: use 4.8.2-rc.1

* docs: add release candidate notes

* refactor: warn plugin range incompatibble

* chore: bump version 4.8.2
---
 CHANGELOG.md              | 12 ++++++++++++
 ci/helm-chart/Chart.yaml  |  4 ++--
 ci/helm-chart/values.yaml |  2 +-
 docs/MAINTAINING.md       | 11 ++++++++++-
 package.json              |  2 +-
 src/node/plugin.ts        |  2 +-
 6 files changed, 27 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index d048fd0b8..6f5ebb121 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -20,6 +20,18 @@ Code v99.99.999
 
 -->
 
+## [4.8.2](https://github.com/coder/code-server/releases/tag/v4.8.2) - 2022-11-02
+
+Code v1.72.1
+
+### Added
+
+- New text in the Getting Started page with info about
+  `coder/coder`. This is enabled by default but can be disabled by passing the CLI
+  flag `--disable-getting-started-override` or setting
+  `CS_DISABLE_GETTING_STARTED_OVERRIDE=1` or
+  `CS_DISABLE_GETTING_STARTED_OVERRIDE=true`.
+
 ## [4.8.1](https://github.com/coder/code-server/releases/tag/v4.8.1) - 2022-10-28
 
 Code v1.72.1
diff --git a/ci/helm-chart/Chart.yaml b/ci/helm-chart/Chart.yaml
index 72abd82ba..8e483c788 100644
--- a/ci/helm-chart/Chart.yaml
+++ b/ci/helm-chart/Chart.yaml
@@ -15,9 +15,9 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 3.3.1
+version: 3.3.2
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
-appVersion: 4.8.1
+appVersion: 4.8.2
diff --git a/ci/helm-chart/values.yaml b/ci/helm-chart/values.yaml
index 36cfdda51..bbea93944 100644
--- a/ci/helm-chart/values.yaml
+++ b/ci/helm-chart/values.yaml
@@ -6,7 +6,7 @@ replicaCount: 1
 
 image:
   repository: codercom/code-server
-  tag: '4.8.1'
+  tag: '4.8.2'
   pullPolicy: Always
 
 # Specifies one or more secrets to be used when pulling images from a
diff --git a/docs/MAINTAINING.md b/docs/MAINTAINING.md
index 6956bb669..6ce83d493 100644
--- a/docs/MAINTAINING.md
+++ b/docs/MAINTAINING.md
@@ -15,6 +15,7 @@
   - [Changelog](#changelog)
 - [Releases](#releases)
   - [Publishing a release](#publishing-a-release)
+    - [Release Candidates](#release-candidates)
     - [AUR](#aur)
     - [Docker](#docker)
     - [Homebrew](#homebrew)
@@ -141,7 +142,7 @@ changelog](https://github.com/emacs-mirror/emacs/blob/master/etc/NEWS).
 
 ### Publishing a release
 
-1. Create a new branch called `release`
+1. Create a new branch called `release/v0.0.0` (replace 0s with actual version aka v4.5.0)
 1. Run `yarn release:prep`
 1. Bump chart version in `Chart.yaml`.
 1. Summarize the major changes in the `CHANGELOG.md`
@@ -152,6 +153,14 @@ changelog](https://github.com/emacs-mirror/emacs/blob/master/etc/NEWS).
    artifacts, publish the NPM package from `npm-package`, and publish the Docker
    Hub image from `release-images`.
 
+#### Release Candidates
+
+We prefer to do release candidates so the community can test things before a full-blown release. To do this follow the same steps as above but:
+
+1. Only bump version in `package.json`
+1. use `0.0.0-rc.0`
+1. When you publish the release, select "pre-release"
+
 #### AUR
 
 We publish to AUR as a package [here](https://aur.archlinux.org/packages/code-server/). This process is manual and can be done by following the steps in [this repo](https://github.com/coder/code-server-aur).
diff --git a/package.json b/package.json
index 40e3a21e0..eb0939573 100644
--- a/package.json
+++ b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "code-server",
   "license": "MIT",
-  "version": "4.8.1",
+  "version": "4.8.2",
   "description": "Run VS Code on a remote server.",
   "homepage": "https://github.com/coder/code-server",
   "bugs": {
diff --git a/src/node/plugin.ts b/src/node/plugin.ts
index 69f32720c..85c588c9a 100644
--- a/src/node/plugin.ts
+++ b/src/node/plugin.ts
@@ -227,7 +227,7 @@ export class PluginAPI {
 `)
     }
     if (!semver.satisfies(version, packageJSON.engines["code-server"])) {
-      throw new Error(
+      this.logger.warn(
         `plugin range ${q(packageJSON.engines["code-server"])} incompatible` + ` with code-server version ${version}`,
       )
     }