Archived
1
0

refactor: remove --home flag/feature

We are removing this because it was removed upstream in PR~115599.
This commit is contained in:
Joe Previte 2021-03-16 12:18:33 -07:00
parent ae02023454
commit 0c2708302d
No known key found for this signature in database
GPG Key ID: 2C91590C6B742C24
5 changed files with 31 additions and 51 deletions

View File

@ -40,7 +40,7 @@ jobs:
- uses: microsoft/playwright-github-action@v1 - uses: microsoft/playwright-github-action@v1
- name: Install dependencies and run tests - name: Install dependencies and run tests
run: | run: |
./release-packages/code-server*-linux-amd64/bin/code-server --home $CODE_SERVER_ADDRESS/healthz & ./release-packages/code-server*-linux-amd64/bin/code-server &
yarn --frozen-lockfile yarn --frozen-lockfile
yarn test yarn test
- name: Upload test artifacts - name: Upload test artifacts

View File

@ -16,9 +16,6 @@ main() {
echo " \$PASSWORD" echo " \$PASSWORD"
echo " \$CODE_SERVER_ADDRESS" echo " \$CODE_SERVER_ADDRESS"
echo -e "\n" echo -e "\n"
echo "Please make sure you have code-server running locally with the flag:"
echo " --home \$CODE_SERVER_ADDRESS/healthz "
echo -e "\n"
exit 1 exit 1
fi fi
CS_DISABLE_PLUGINS=true ./test/node_modules/.bin/jest "$@" CS_DISABLE_PLUGINS=true ./test/node_modules/.bin/jest "$@"

View File

@ -2,36 +2,36 @@
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE --> <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
# FAQ # FAQ
- [Questions?](#questions) - [FAQ](#faq)
- [iPad Status?](#ipad-status) - [Questions?](#questions)
- [Community Projects (awesome-code-server)](#community-projects-awesome-code-server) - [iPad Status?](#ipad-status)
- [How can I reuse my VS Code configuration?](#how-can-i-reuse-my-vs-code-configuration) - [Community Projects (awesome-code-server)](#community-projects-awesome-code-server)
- [Differences compared to VS Code?](#differences-compared-to-vs-code) - [How can I reuse my VS Code configuration?](#how-can-i-reuse-my-vs-code-configuration)
- [How can I request a missing extension?](#how-can-i-request-a-missing-extension) - [Differences compared to VS Code?](#differences-compared-to-vs-code)
- [How do I configure the marketplace URL?](#how-do-i-configure-the-marketplace-url) - [How can I request a missing extension?](#how-can-i-request-a-missing-extension)
- [Where are extensions stored?](#where-are-extensions-stored) - [How do I configure the marketplace URL?](#how-do-i-configure-the-marketplace-url)
- [How is this different from VS Code Codespaces?](#how-is-this-different-from-vs-code-codespaces) - [Where are extensions stored?](#where-are-extensions-stored)
- [How should I expose code-server to the internet?](#how-should-i-expose-code-server-to-the-internet) - [How is this different from VS Code Codespaces?](#how-is-this-different-from-vs-code-codespaces)
- [Can I store my password hashed?](#can-i-store-my-password-hashed) - [How should I expose code-server to the internet?](#how-should-i-expose-code-server-to-the-internet)
- [How do I securely access web services?](#how-do-i-securely-access-web-services) - [Can I store my password hashed?](#can-i-store-my-password-hashed)
- [How do I securely access web services?](#how-do-i-securely-access-web-services)
- [Sub-paths](#sub-paths) - [Sub-paths](#sub-paths)
- [Sub-domains](#sub-domains) - [Sub-domains](#sub-domains)
- [Why does the code-server proxy strip `/proxy/<port>` from the request path?](#why-does-the-code-server-proxy-strip-proxyport-from-the-request-path) - [Why does the code-server proxy strip `/proxy/<port>` from the request path?](#why-does-the-code-server-proxy-strip-proxyport-from-the-request-path)
- [Proxying to Create React App](#proxying-to-create-react-app) - [Proxying to Create React App](#proxying-to-create-react-app)
- [Multi-tenancy](#multi-tenancy) - [Multi-tenancy](#multi-tenancy)
- [Docker in code-server container?](#docker-in-code-server-container) - [Docker in code-server container?](#docker-in-code-server-container)
- [How can I disable telemetry?](#how-can-i-disable-telemetry) - [How can I disable telemetry?](#how-can-i-disable-telemetry)
- [How does code-server decide what workspace or folder to open?](#how-does-code-server-decide-what-workspace-or-folder-to-open) - [How does code-server decide what workspace or folder to open?](#how-does-code-server-decide-what-workspace-or-folder-to-open)
- [How do I debug issues with code-server?](#how-do-i-debug-issues-with-code-server) - [How do I debug issues with code-server?](#how-do-i-debug-issues-with-code-server)
- [Heartbeat File](#heartbeat-file) - [Heartbeat File](#heartbeat-file)
- [Healthz endpoint](#healthz-endpoint) - [Healthz endpoint](#healthz-endpoint)
- [How does the config file work?](#how-does-the-config-file-work) - [How does the config file work?](#how-does-the-config-file-work)
- [How do I customize the "Go Home" button?](#how-do-i-customize-the-go-home-button) - [Isn't an install script piped into sh insecure?](#isnt-an-install-script-piped-into-sh-insecure)
- [Isn't an install script piped into sh insecure?](#isnt-an-install-script-piped-into-sh-insecure) - [How do I make my keyboard shortcuts work?](#how-do-i-make-my-keyboard-shortcuts-work)
- [How do I make my keyboard shortcuts work?](#how-do-i-make-my-keyboard-shortcuts-work) - [Differences compared to Theia?](#differences-compared-to-theia)
- [Differences compared to Theia?](#differences-compared-to-theia) - [`$HTTP_PROXY`, `$HTTPS_PROXY`, `$NO_PROXY`](#http_proxy-https_proxy-no_proxy)
- [`$HTTP_PROXY`, `$HTTPS_PROXY`, `$NO_PROXY`](#http_proxy-https_proxy-no_proxy) - [Enterprise](#enterprise)
- [Enterprise](#enterprise)
<!-- END doctoc generated TOC please keep comment here to allow auto update --> <!-- END doctoc generated TOC please keep comment here to allow auto update -->
@ -354,16 +354,6 @@ The `--config` flag or `$CODE_SERVER_CONFIG` can be used to change the config fi
The default location also respects `$XDG_CONFIG_HOME`. The default location also respects `$XDG_CONFIG_HOME`.
## How do I customize the "Go Home" button?
You can pass a URL to the `--home` flag like this:
```
code-server --home=https://my-website.com
```
Or you can define it in the config file with `home`.
## Isn't an install script piped into sh insecure? ## Isn't an install script piped into sh insecure?
Please give Please give

View File

@ -56,7 +56,6 @@ export interface Args extends VsArgs {
"new-window"?: boolean "new-window"?: boolean
link?: OptionalString link?: OptionalString
home?: string
} }
interface Option<T> { interface Option<T> {
@ -201,10 +200,6 @@ const options: Options<Required<Args>> = {
`, `,
beta: true, beta: true,
}, },
home: {
type: "string",
description: "Set a custom link for the 'Go Home' button in the Application Menu",
},
} }
export const optionDescriptions = (): string[] => { export const optionDescriptions = (): string[] => {

View File

@ -55,7 +55,6 @@ describe("parser", () => {
"--log", "--log",
"error", "error",
"--help", "--help",
"--home=http://localhost:8080/",
"--open", "--open",
"--socket=mumble", "--socket=mumble",
"3", "3",
@ -86,7 +85,6 @@ describe("parser", () => {
"extra-builtin-extensions-dir": [path.resolve("bazzle")], "extra-builtin-extensions-dir": [path.resolve("bazzle")],
"extra-extensions-dir": [path.resolve("nozzle")], "extra-extensions-dir": [path.resolve("nozzle")],
help: true, help: true,
home: "http://localhost:8080/",
host: "0.0.0.0", host: "0.0.0.0",
json: true, json: true,
log: "error", log: "error",