OCram85/code-server
Archived
1
0
Fork 0
Code Pull Requests 2 Activity

feat: add e2e test for logout

Browse Source
This commit is contained in:
Joe Previte
2021-03-17 16:23:17 -07:00
parent 5cec6208d0
commit 090687d057
4 changed files with 68 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/vscode/src/vs/server/common/cookie.ts
View File

@ -1,3 +1,3 @@
export enum Cookie {
Key = "key",
}
Key = 'key',
}

9
lib/vscode/src/vs/workbench/browser/parts/titlebar/menubarControl.ts
View File

@ -9,8 +9,7 @@ import { registerThemingParticipant, IThemeService } from 'vs/platform/theme/com
import { MenuBarVisibility, getTitleBarStyle, IWindowOpenable, getMenuBarVisibility } from 'vs/platform/windows/common/windows';
import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
import { IAction, Action, SubmenuAction, Separator } from 'vs/base/common/actions';
import * as DOM from 'vs/base/browser/dom';
import { addDisposableListener, Dimension, EventType } from 'vs/base/browser/dom';
import { addDisposableListener, Dimension, EventType, getCookieValue } from 'vs/base/browser/dom';
import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
import { isMacintosh, isWeb, isIOS, isNative } from 'vs/base/common/platform';
import { IConfigurationService, IConfigurationChangeEvent } from 'vs/platform/configuration/common/configuration';
@ -717,8 +716,8 @@ export class CustomMenubarControl extends MenubarControl {
webNavigationActions.push(new Action('logout', localize('logout', "Log out"), undefined, true,
async (event?: MouseEvent) => {
const COOKIE_KEY = 'key';
const loginCookie = DOM.getCookieValue(COOKIE_KEY);
const COOKIE_KEY = Cookie.Key;
const loginCookie = getCookieValue(COOKIE_KEY);
this.logService.info('Logging out of code-server');
@ -735,7 +734,7 @@ export class CustomMenubarControl extends MenubarControl {
} else {
this.logService.warn('Could not log out because we could not find cookie');
}
}))
}));
return webNavigationActions;
}