Fix string quoting. This is not using string expansion, so it's not needed to use double-quotes.

.drone.yml

@@ -120,7 +120,7 @@ steps:
           Install-Module -Name 'DroneHelper' -Repository 'PSGallery' -ErrorAction 'Stop' -AllowPrerelease -Force;
           Import-Module -Name 'DroneHelper' -ErrorAction 'Stop';
           Install-ModuleDependency;
-          New-BuildPackage -Verbose -AdditionalPath @('./src/Vendor', './src/openssl.conf')
+          New-BuildPackage -Verbose
         }"
 
   - name: GiteaRelease

.gitattributes

@@ -21,5 +21,4 @@
 
 # Vendor resources config
 src/Vendor/libressl255/* filter=lfs diff=lfs merge=lfs -text
-src/Vendor/libressl/* filter=lfs diff=lfs merge=lfs -text
 *.pfx filter=lfs diff=lfs merge=lfs -text

CHANGELOG.md

@@ -3,9 +3,7 @@
 <!-- insertMark -->
 ## `v1.1.0`
 
-- (3d4f53d) adds pinguinfuss contributed fix (#73)
-- (6fce8d6) Updates libressl files (#71)
-- (ddb85d9) addChangelog (#70)
+- (acb09ba) update Changelog
 - (5bdb383) updates Readme (#69)
 - (a95ba31) remove optional depenency helper (#68)
 - (1e7dd78) adds CiscoUCSCentral connection type (#67)
@@ -22,6 +20,7 @@
 - (4abfec5) adds PR template (#55)
 - (7708df9) Update pwsh style to latest community standards (#52)
 
+
 ## `v1.0.542`
 
 - 🧙 pre migrated Gitea version

src/Certificate/New-CSCertificate.ps1

@@ -66,7 +66,7 @@ function New-CSCertificate {
             ($PSVersionTable.PSEdition -eq 'Desktop' -and $PSVersionTable.PSVersion.Major -lt 6) -or
             ($IsWindows -eq $true)
         ) {
-            $openssl = Join-Path -Path $ModuleBase -ChildPath '/Vendor/libressl/openssl.exe'
+            $openssl = Join-Path -Path $ModuleBase -ChildPath '/Vendor/libressl255/openssl.exe'
         }
 
         $Env:OPENSSL_CONF = Join-Path $ModuleBase -ChildPath '/openssl.conf'

src/Item/New-CredentialStoreItem.Tests.ps1

@@ -102,7 +102,7 @@ Describe "New-CredentialStoreItem" {
         It "Missing CredentialStore should throw" {
             {
                 New-CredentialStoreItem -Shared -Path '/tmp/missingStore.json' -RemoteHost 'notrelevant'
-            } | Should -Throw "The given credential store (/tmp/missingStore.json) does not exist!"
+            } | Should -Throw "Could not add anything into the given CredentialStore."
         }
     }
     Context "Testing pipeline paramter" {

src/Item/New-CredentialStoreItem.ps1

@@ -1,168 +1,168 @@
-function New-CredentialStoreItem {
-    <#
-    .SYNOPSIS
-        Adds a credential store item containing host, user and password to the given store.
-
-    .DESCRIPTION
-        The credentials are stored without any relations to it's further use. If you need to change an existing
-        item please use Set-CredentialStoreItem. You need to decide afterwards, whether to use the credential for
-        a VIConnection, NetApp FAS or UCS Fabric Interconnect.
-
-    .PARAMETER Path
-        Define the store in which you would like to add a new item.
-
-    .PARAMETER RemoteHost
-        The identifier or rather name for the given credentials.
-
-    .PARAMETER Identifier
-        Provide a custom identifier to the given remote host key. This enables you to store multiple credentials
-        for a single remote host entry. For example ad/sys1, ftp/sys1, mssql/sys1
-
-    .PARAMETER Credential
-        You can provide credentials optionally as pre existing pscredential object.
-
-    .PARAMETER Shared
-        Define the CredentialStore where you want to add the new item. Default is always personal but can be
-        changed to shared, or even shared with custom path.
-
-    .INPUTS
-        [None]
-
-    .OUTPUTS
-        [None]
-
-    .EXAMPLE
-        New-CredentialStoreItem -Path 'C:\TMP\mystore.json' -RemoteHost esx01.myside.local'
-    #>
-
-    [CmdletBinding(DefaultParameterSetName = 'Private')]
-    [Diagnostics.CodeAnalysis.SuppressMessageAttribute(
-        'PSUseShouldProcessForStateChangingFunctions',
-        '',
-        Justification = 'Adds data into an existing object/file'
-    )]
-    param (
-        [Parameter(Mandatory = $true, ParameterSetName = 'Shared')]
-        [Parameter(Mandatory = $true, ParameterSetName = 'Private')]
-        [ValidateNotNullOrEmpty()]
-        [string]$RemoteHost,
-
-        [Parameter(Mandatory = $false, ParameterSetName = 'Shared')]
-        [Parameter(Mandatory = $false, ParameterSetName = 'Private')]
-        [ValidateNotNullOrEmpty()]
-        [string]$Identifier,
-
-        [Parameter(Mandatory = $false, ValueFromPipeline = $true)]
-        [ValidateNotNullOrEmpty()]
-        [PSCredential]$Credential,
-
-        [Parameter(Mandatory = $true, ParameterSetName = 'Shared')]
-        [switch]$Shared,
-
-        [Parameter(Mandatory = $false, ParameterSetName = 'Shared')]
-        [ValidateNotNullOrEmpty()]
-        [string]$Path
-
-
-    )
-
-    begin {
-        # Set the CredentialStore for private, shared or custom mode.
-        Write-Debug ('ParameterSetName: {0}' -f $PSCmdlet.ParameterSetName)
-        if ($PSCmdlet.ParameterSetName -eq 'Private') {
-            $Path = Get-DefaultCredentialStorePath
-        }
-        elseif ($PSCmdlet.ParameterSetName -eq 'Shared') {
-            if (!($PSBoundParameters.ContainsKey('Path'))) {
-                $Path = Get-DefaultCredentialStorePath -Shared
-            }
-        }
-    }
-
-    process {
-        # Lets do a quick test on the given CredentialStore.
-        if (-not(Test-CredentialStore -Shared -Path $Path)) {
-            $MessageParams = @{
-                Exception   = [System.IO.FileNotFoundException]::new(
-                    'The given credential store ({0}) does not exist!' -f $Path
-                )
-                ErrorAction = 'Stop'
-            }
-            Write-Error @MessageParams
-        }
-
-        $CSContent = Get-CredentialStore -Shared -Path $Path
-
-        $CurrentDate = Get-Date -Format 'u'
-
-        if ($Identifier -ne '') {
-            $CredentialName = $RemoteHost = '{0}/{1}' -f $Identifier, $RemoteHost
-        }
-        else {
-            $CredentialName = $RemoteHost
-        }
-
-        if (-not($Credential)) {
-            $Credential = Get-Credential -Message $CredentialName
-        }
-
-        if ($Credential.UserName) {
-            if ($null -eq $CSContent.PfxCertificate) {
-                $Cert = Get-CSCertificate -Type $CSContent.Type -Thumbprint $CSContent.Thumbprint
-            }
-            else {
-                $Cert = Get-PfxCertificate -FilePath $CSContent.PfxCertificate -ErrorAction Stop
-            }
-
-            if (Get-Member -InputObject $CSContent -Name $CredentialName -MemberType Properties) {
-                $MessageParams = @{
-                    Message = 'The given host already exists. Nothing to do here.'
-                }
-                Write-Warning @MessageParams
-            }
-            else {
-                $RSAKey = Get-RandomAESKey
-
-                $CredentialHash = [ordered]@{
-                    User         = $Credential.UserName
-                    Password     = ConvertFrom-SecureString -SecureString $Credential.Password -Key $RSAKey
-                    Created      = $CurrentDate
-                    LastChange   = $null
-                    EncryptedKey = [Convert]::ToBase64String(
-                        $Cert.PublicKey.Key.Encrypt(
-                            $RSAKey,
-                            [System.Security.Cryptography.RSAEncryptionPadding]::Pkcs1
-                        )
-                    )
-                }
-                $MemberParams = @{
-                    InputObject = $CSContent
-                    Name        = $CredentialName
-                    MemberType  = 'NoteProperty'
-                    Value       = $CredentialHash
-                }
-                Add-Member @MemberParams
-                try {
-                    ConvertTo-Json -InputObject $CSContent | Out-File -FilePath $Path
-                }
-                catch {
-                    $MessageParams = @{
-                        Message     = 'Could not add item into credential store!'
-                        ErrorAction = 'Stop'
-                    }
-                    Write-Error @MessageParams
-                }
-            }
-        }
-        else {
-            $MessageParams = @{
-                Message     = 'Please Provide at least a valid user!'
-                ErrorAction = 'Stop'
-            }
-            Write-Error @MessageParams
-        }
-    }
-
-    end {}
-
-}
+function New-CredentialStoreItem {
+    <#
+    .SYNOPSIS
+        Adds a credential store item containing host, user and password to the given store.
+
+    .DESCRIPTION
+        The credentials are stored without any relations to it's further use. If you need to change an existing
+        item please use Set-CredentialStoreItem. You need to decide afterwards, whether to use the credential for
+        a VIConnection, NetApp FAS or UCS Fabric Interconnect.
+
+    .PARAMETER Path
+        Define the store in which you would like to add a new item.
+
+    .PARAMETER RemoteHost
+        The identifier or rather name for the given credentials.
+
+    .PARAMETER Identifier
+        Provide a custom identifier to the given remote host key. This enables you to store multiple credentials
+        for a single remote host entry. For example ad/sys1, ftp/sys1, mssql/sys1
+
+    .PARAMETER Credential
+        You can provide credentials optionally as pre existing pscredential object.
+
+    .PARAMETER Shared
+        Define the CredentialStore where you want to add the new item. Default is always personal but can be
+        changed to shared, or even shared with custom path.
+
+    .INPUTS
+        [None]
+
+    .OUTPUTS
+        [None]
+
+    .EXAMPLE
+        New-CredentialStoreItem -Path 'C:\TMP\mystore.json' -RemoteHost 'esx01.myside.local'
+    #>
+
+    [CmdletBinding(DefaultParameterSetName = 'Private')]
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute(
+        'PSUseShouldProcessForStateChangingFunctions',
+        '',
+        Justification = 'Adds data into an existing object/file'
+    )]
+    param (
+        [Parameter(Mandatory = $true, ParameterSetName = 'Shared')]
+        [Parameter(Mandatory = $true, ParameterSetName = 'Private')]
+        [ValidateNotNullOrEmpty()]
+        [string]$RemoteHost,
+
+        [Parameter(Mandatory = $false, ParameterSetName = 'Shared')]
+        [Parameter(Mandatory = $false, ParameterSetName = 'Private')]
+        [ValidateNotNullOrEmpty()]
+        [string]$Identifier,
+
+        [Parameter(Mandatory = $false, ValueFromPipeline = $true)]
+        [ValidateNotNullOrEmpty()]
+        [PSCredential]$Credential,
+
+        [Parameter(Mandatory = $true, ParameterSetName = 'Shared')]
+        [switch]$Shared,
+
+        [Parameter(Mandatory = $false, ParameterSetName = 'Shared')]
+        [ValidateNotNullOrEmpty()]
+        [string]$Path
+
+
+    )
+
+    begin {
+        # Set the CredentialStore for private, shared or custom mode.
+        Write-Debug ('ParameterSetName: {0}' -f $PSCmdlet.ParameterSetName)
+        if ($PSCmdlet.ParameterSetName -eq 'Private') {
+            $Path = Get-DefaultCredentialStorePath
+        }
+        elseif ($PSCmdlet.ParameterSetName -eq 'Shared') {
+            if (!($PSBoundParameters.ContainsKey('Path'))) {
+                $Path = Get-DefaultCredentialStorePath -Shared
+            }
+        }
+    }
+
+    process {
+        # Lets do a quick test on the given CredentialStore.
+        if (-not(Test-CredentialStore -Shared -Path $Path)) {
+            $MessageParams = @{
+                Exception   = [System.IO.FileNotFoundException]::new(
+                    'The given credential store ({0}) does not exist!' -f $Path
+                )
+                ErrorAction = 'Stop'
+            }
+            Write-Error @MessageParams
+        }
+
+        $CSContent = Get-CredentialStore -Shared -Path $Path
+
+        $CurrentDate = Get-Date -Format 'u'
+
+        if ($Identifier -ne '') {
+            $CredentialName = $RemoteHost = '{0}/{1}' -f $Identifier, $RemoteHost
+        }
+        else {
+            $CredentialName = $RemoteHost
+        }
+
+        if (-not($Credential)) {
+            $Credential = Get-Credential -Message $CredentialName
+        }
+
+        if ($Credential.UserName) {
+            if ($null -eq $CSContent.PfxCertificate) {
+                $Cert = Get-CSCertificate -Type $CSContent.Type -Thumbprint $CSContent.Thumbprint
+            }
+            else {
+                $Cert = Get-PfxCertificate -FilePath $CSContent.PfxCertificate -ErrorAction Stop
+            }
+
+            if (Get-Member -InputObject $CSContent -Name $CredentialName -MemberType Properties) {
+                $MessageParams = @{
+                    Message = 'The given host already exists. Nothing to do here.'
+                }
+                Write-Warning @MessageParams
+            }
+            else {
+                $RSAKey = Get-RandomAESKey
+
+                $CredentialHash = [ordered]@{
+                    User         = $Credential.UserName
+                    Password     = ConvertFrom-SecureString -SecureString $Credential.Password -Key $RSAKey
+                    Created      = $CurrentDate
+                    LastChange   = $null
+                    EncryptedKey = [Convert]::ToBase64String(
+                        $Cert.PublicKey.Key.Encrypt(
+                            $RSAKey,
+                            [System.Security.Cryptography.RSAEncryptionPadding]::Pkcs1
+                        )
+                    )
+                }
+                $MemberParams = @{
+                    InputObject = $CSContent
+                    Name        = $CredentialName
+                    MemberType  = 'NoteProperty'
+                    Value       = $CredentialHash
+                }
+                Add-Member @MemberParams
+                try {
+                    ConvertTo-Json -InputObject $CSContent | Out-File -FilePath $Path
+                }
+                catch {
+                    $MessageParams = @{
+                        Message     = 'Could not add item into credential store!'
+                        ErrorAction = 'Stop'
+                    }
+                    Write-Error @MessageParams
+                }
+            }
+        }
+        else {
+            $MessageParams = @{
+                Message     = 'Please Provide at least a valid user!'
+                ErrorAction = 'Stop'
+            }
+            Write-Error @MessageParams
+        }
+    }
+
+    end {}
+
+}