fix git config arguments (#68)

#### 📖 Summary

- changed argument passing and testing in sub function

#### 📑 Test Plan

> 💡 Select your test plan for the code changes.

| Choice | Test Method       |
| :----: | :-----------      |
|   ✅   | CI pipeline tests |
|        | Custom test       |
|        | No test plan      |

##### Details / Justification

<!-- Add your test details or justification for missing tests here. -->

#### 📚 Additional Notes

- fixes #66

Co-authored-by: OCram85 <marco.blessing@googlemail.com>
Reviewed-on: #68

arkanum

@@ -243,13 +243,24 @@ EOF
 }
 
 function setGitConfig() {
-  if [[ "$#" != "2" ]]; then
-    sayE "Invalid arguments given. Please provide '<user>' and 'email'!" "Git"
+  #echo "function arg counter is; $#"
+  #echo "function args:$@"
+
+  if [[ "$#" != "4" ]]; then
+    sayE "Invalid arguments given. Please provide '<user>' and '<email>'!" "Git"
+    exit 1
+  fi
+  if [[ -z "$3" ]]; then
+    sayE "Invalid or empty username given!" "Git"
+    exit 1
+  fi
+  if [[ -z "$4" ]]; then
+    sayE "Invalid or empty email given!" "Git"
     exit 1
   fi
   say "Setting global git config..." "Git"
-  git config --global user.name "$1"
-  git config --global user.email "$2"
+  git config --global user.name "$3"
+  git config --global user.email "$4"
   say "Returning global config:" "Git"
   git config --list --global
 }
@@ -287,7 +298,7 @@ function main() {
   elif [[ "$1" == "git" ]]; then
     # setup option
     if [[ "$2" == "setup" ]]; then
-      setGitConfig "$3" "$4"
+      setGitConfig "$@"
     else
       sayE "Unknown option ($2) given for command 'git'!"
     fi